Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate the list of allowed file names when extracting files from zip folder #2221 #2230

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

files can be extracted outside the destination folder

Solutions

limit the set of file names that are allowed to be extracted

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…rm zip folder (#2221)

* fix: validate the list of allowed file names when extracting files form  zip folder

* detekt

* fix tests

* detekt

(cherry picked from commit d6c8d60)
@MohamadJaara MohamadJaara changed the title fix: validate the list of allowed file names when extracting files fo… fix: validate the list of allowed file names when extracting files form zip folder #2221 Nov 16, 2023
@MohamadJaara MohamadJaara changed the title fix: validate the list of allowed file names when extracting files form zip folder #2221 fix: validate the list of allowed file names when extracting files from zip folder #2221 Nov 16, 2023
@MohamadJaara MohamadJaara requested review from a team, typfel, gongracr, yamilmedina, alexandreferris and ohassine and removed request for a team November 16, 2023 12:24
@MohamadJaara MohamadJaara changed the title fix: validate the list of allowed file names when extracting files from zip folder #2221 fix: validate the list of allowed file names when extracting files from zip folder #2221 Nov 16, 2023
Copy link
Contributor

github-actions bot commented Nov 16, 2023

Unit Test Results

   431 files     431 suites   17s ⏱️
2 437 tests 2 359 ✔️ 78 💤 0

Results for commit 857b7e7.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara enabled auto-merge (squash) November 16, 2023 16:18
@MohamadJaara MohamadJaara merged commit 3b94f7e into release/candidate Nov 16, 2023
15 checks passed
@MohamadJaara MohamadJaara deleted the fix/validate-allowed-file-names-when-extracting-zip-files branch November 16, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants