Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(applock): team app lock dialog displayed when changing timeout (RC) - cherrypick #2234

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

cherrypick of #2232

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Unit Test Results

   439 files     439 suites   19s ⏱️
2 486 tests 2 383 ✔️ 103 💤 0

Results for commit 6629c0d.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara enabled auto-merge (squash) November 16, 2023 17:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@1320279). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2234   +/-   ##
====================================================
  Coverage                     ?   58.09%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1073           
  Lines                        ?    40758           
  Branches                     ?     3775           
====================================================
  Hits                         ?    23678           
  Misses                       ?    15461           
  Partials                     ?     1619           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1320279...6629c0d. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 17, 2023

Datadog Report

All test runs 0634673 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2193 66 7m 8.11s Link
kalium-jvm 0 0 0 2526 104 7m 13.04s Link

@MohamadJaara MohamadJaara merged commit 884b41a into release/candidate Nov 21, 2023
17 checks passed
@MohamadJaara MohamadJaara deleted the team_change_app_lock_rc branch November 21, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants