-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: new 1on1 conversation not visible on list [WPB-5551] #2237
Merged
saleniuk
merged 2 commits into
release/candidate
from
fix/invisible-new-1on1-conversation
Nov 20, 2023
Merged
fix: new 1on1 conversation not visible on list [WPB-5551] #2237
saleniuk
merged 2 commits into
release/candidate
from
fix/invisible-new-1on1-conversation
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
Nov 20, 2023
MohamadJaara
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as always, as communicated in 1:1 we need to double-check if this issue is present in 4.4.x
saleniuk
requested review from
a team,
borichellow,
vitorhugods,
mchenani,
Garzas and
ohassine
and removed request for
a team
November 20, 2023 13:58
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
alexandreferris
approved these changes
Nov 20, 2023
7 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
* fix: new 1on1 conversation not visible on list [WPB-5551] * remove unneeded observation and add tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
* fix: new 1on1 conversation not visible on list [WPB-5551] (#2237) * fix: new 1on1 conversation not visible on list [WPB-5551] * remove unneeded observation and add tests * trigger build --------- Co-authored-by: Michał Saleniuk <[email protected]> Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
New 1on1 conversations are not visible on conversation list until the user sends any message.
Causes (Optional)
After some recent updates with implementing protocols migration, it's now necessary for the user's
active_one_on_one_conversation_id
field to match the 1on1 conversation id, otherwise it's not added to the list.Resolving 1on1 conversations that executes protocol migration and results in filling in this field is executed when syncing conversations, creating a new one, accepting connection request or handling new connection, receiving MLS
conversation.mls-welcome
event, but has been missing for Proteusconversation.create
event.The conversation was appearing after the user sent a message because then it executes
GetOrCreateOneToOneConversation
which also resolves one on one conversation if can't be found (which also means whenactive_one_on_one_conversation_id
is not set properly).Solutions
Execute
OneOnOneResolver
also when Proteusconversation.create
event is received.Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.