Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new 1on1 conversation not visible on list [WPB-5551] #2237

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

New 1on1 conversations are not visible on conversation list until the user sends any message.

Causes (Optional)

After some recent updates with implementing protocols migration, it's now necessary for the user's active_one_on_one_conversation_id field to match the 1on1 conversation id, otherwise it's not added to the list.
Resolving 1on1 conversations that executes protocol migration and results in filling in this field is executed when syncing conversations, creating a new one, accepting connection request or handling new connection, receiving MLS conversation.mls-welcome event, but has been missing for Proteus conversation.create event.
The conversation was appearing after the user sent a message because then it executes GetOrCreateOneToOneConversation which also resolves one on one conversation if can't be found (which also means when active_one_on_one_conversation_id is not set properly).

Solutions

Execute OneOnOneResolver also when Proteus conversation.create event is received.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • user A and B have no conversation
  • user A and B use Proteus protocol and at least one does not support MLS protocol (so that MLS can't be used for their 1on1 conversation)
  • user B finds user A, opens 1on1 conversation with user A and sends a message
  • user A can see this new 1on1 conversation on the conversation list even before he/she writes anything in this conversation

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always, as communicated in 1:1 we need to double-check if this issue is present in 4.4.x

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Unit Test Results

   439 files     439 suites   27s ⏱️
2 487 tests 2 384 ✔️ 103 💤 0

Results for commit d864f60.

♻️ This comment has been updated with latest results.

@saleniuk
Copy link
Contributor Author

we need to double-check if this issue is present in 4.4.x

#2015
#2164

These PRs were added to the develop which was 4.5.x at that time and these commits can't be found in android-cycle-4.4.x

@saleniuk saleniuk requested review from a team, borichellow, vitorhugods, mchenani, Garzas and ohassine and removed request for a team November 20, 2023 13:58
@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 20, 2023

Datadog Report

All test runs 5d60ee4 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2384 103 9m 8.1s Link
kalium-jvm 0 0 0 2529 104 7m 17.05s Link

@saleniuk saleniuk merged commit 1320279 into release/candidate Nov 20, 2023
18 checks passed
@saleniuk saleniuk deleted the fix/invisible-new-1on1-conversation branch November 20, 2023 15:13
github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
* fix: new 1on1 conversation not visible on list [WPB-5551]

* remove unneeded observation and add tests
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2023
* fix: new 1on1 conversation not visible on list [WPB-5551] (#2237)

* fix: new 1on1 conversation not visible on list [WPB-5551]

* remove unneeded observation and add tests

* trigger build

---------

Co-authored-by: Michał Saleniuk <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants