-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add use case to approve legal hold [WPB-4393] #2239
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2239 +/- ##
=============================================
+ Coverage 57.98% 58.00% +0.02%
Complexity 21 21
=============================================
Files 1075 1076 +1
Lines 40817 40859 +42
Branches 3778 3783 +5
=============================================
+ Hits 23666 23699 +33
- Misses 15531 15538 +7
- Partials 1620 1622 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I have approved it but just have two questions
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/team/TeamRepository.kt
Show resolved
Hide resolved
…' into feat/approve_legal_hold_use_case
* feat: add use case to approve legal hold [WPB-4393] * add doc comments * trigger build * update jvm tests * revert jvm tests --------- Co-authored-by: Yamil Medina <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Implementation of the use case, repository method and API call that allows the user to approve the requested legal hold.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.