Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use case to approve legal hold [WPB-4393] #2239

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Implementation of the use case, repository method and API call that allows the user to approve the requested legal hold.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Unit Test Results

   475 files  +  42     475 suites  +42   2m 19s ⏱️ + 1m 54s
2 650 tests +203  2 546 ✔️ +177  104 💤 +26  0 ±0 

Results for commit 1fca7ff. ± Comparison against base commit d7d5a72.

♻️ This comment has been updated with latest results.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and MohamadJaara and removed request for a team November 20, 2023 17:12
@codecov-commenter
Copy link

Codecov Report

Merging #2239 (0f0e3e3) into develop (b80ce0f) will increase coverage by 0.02%.
The diff coverage is 76.19%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2239      +/-   ##
=============================================
+ Coverage      57.98%   58.00%   +0.02%     
  Complexity        21       21              
=============================================
  Files           1075     1076       +1     
  Lines          40817    40859      +42     
  Branches        3778     3783       +5     
=============================================
+ Hits           23666    23699      +33     
- Misses         15531    15538       +7     
- Partials        1620     1622       +2     
Files Coverage Δ
.../com/wire/kalium/logic/data/team/TeamRepository.kt 82.71% <100.00%> (+0.66%) ⬆️
.../kalium/network/api/base/authenticated/TeamsApi.kt 62.06% <75.00%> (+2.06%) ⬆️
.../kalium/network/api/v0/authenticated/TeamsApiV0.kt 52.63% <83.33%> (+5.75%) ⬆️
...logic/feature/legalhold/ApproveLegalHoldUseCase.kt 84.00% <84.00%> (ø)
...in/com/wire/kalium/logic/feature/team/TeamScope.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80ce0f...0f0e3e3. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 20, 2023

Datadog Report

All test runs 7838bcf 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2006 42 6m 33.11s Link
kalium-jvm 0 0 0 2546 104 2h 14m 3.04s Link

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have approved it but just have two questions

@saleniuk saleniuk added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@saleniuk saleniuk added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@ohassine ohassine added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@saleniuk saleniuk added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@saleniuk saleniuk added this pull request to the merge queue Nov 22, 2023
Merged via the queue into develop with commit 7893659 Nov 22, 2023
17 checks passed
@saleniuk saleniuk deleted the feat/approve_legal_hold_use_case branch November 22, 2023 14:51
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
* feat: add use case to approve legal hold [WPB-4393]

* add doc comments

* trigger build

* update jvm tests

* revert jvm tests

---------

Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants