-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: private users can remove app lock even after team enforce #2241
fix: private users can remove app lock even after team enforce #2241
Conversation
* fix: app lock can be changes when enforced and it is cleared when not enforced * add docs
…n-after-team-enforce-cherry-pick
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2241 +/- ##
=============================================
- Coverage 57.95% 57.93% -0.03%
Complexity 21 21
=============================================
Files 1080 1081 +1
Lines 41002 41009 +7
Branches 3793 3793
=============================================
- Hits 23762 23757 -5
- Misses 15618 15631 +13
+ Partials 1622 1621 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
#2241) * fix: app lock can be changes when enforced and it is cleared when not enforced * add docs Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Solutions
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References