Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure and allow cipher suites - negative test checks (WPB-5448) #2242

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

yamilmedina
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

https://wearezeta.atlassian.net/browse/WPB-5448
Follow up of #2193 and #2233

Causes (Optional)

Add required negative check of ciphersuites

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from a team November 21, 2023 15:11
@yamilmedina yamilmedina self-assigned this Nov 21, 2023
@yamilmedina yamilmedina requested review from typfel, mchenani, Garzas, ohassine and saleniuk and removed request for a team November 21, 2023 15:11
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Unit Test Results

   386 files   -   86     386 suites   - 86   9s ⏱️ - 2m 53s
2 035 tests  - 602  1 993 ✔️  - 540  42 💤  - 62  0 ±0 

Results for commit e0b8dde. ± Comparison against base commit 35c87b5.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #2242 (c7215e8) into develop (35c87b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2242   +/-   ##
==========================================
  Coverage      57.99%   57.99%           
  Complexity        21       21           
==========================================
  Files           1075     1075           
  Lines          40824    40824           
  Branches        3778     3778           
==========================================
  Hits           23675    23675           
  Misses         15530    15530           
  Partials        1619     1619           

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c87b5...c7215e8. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 21, 2023

Datadog Report

All test runs 008c6d6 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1993 42 4m 32.01s Link
kalium-jvm 0 0 0 2533 104 7m 35s Link

@yamilmedina yamilmedina added this pull request to the merge queue Nov 21, 2023
Merged via the queue into develop with commit c44dd05 Nov 21, 2023
17 checks passed
@yamilmedina yamilmedina deleted the chore/add-test-ciphersuites branch November 21, 2023 17:10
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
…5448) (#2242)

* chore: more tests for compliance

* chore: structure for helpin script crawler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants