-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create observer for legal hold request (WPB-5442) #2243
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
…_request # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/configuration/UserConfigRepository.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/legalhold/LastPreKey.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/receiver/handler/legalhold/LegalHoldRequestHandler.kt # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/unread/UserConfigDAO.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 🚀 Just small comment about logger
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/legalhold/LegalHoldRequestObserver.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/legalhold/LegalHoldRequestObserver.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/legalhold/LegalHoldRequestObserver.kt
Outdated
Show resolved
Hide resolved
… observe_legal_hold_request
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2243 +/- ##
=============================================
- Coverage 57.94% 57.93% -0.02%
Complexity 21 21
=============================================
Files 1082 1084 +2
Lines 41053 41084 +31
Branches 3798 3801 +3
=============================================
+ Hits 23789 23801 +12
- Misses 15640 15659 +19
Partials 1624 1624
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* feat: handle legal hold events * chore: address comments * chore: detekt * chore: detekt * feat: create use case to observe legal hold request * chore: detekt * chore: detekt * chore: cleanup * chore: address comments * chore: use case documentation
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Description
In this PR, I created an observer that will observe legal hold request that is stored locally.
It will return
LegalHoldRequestAvailable
with the fingerprint if there is a request ,NoLegalHoldRequest
in case no request is pending and failure in case of something went wrongNote:
This PR includes changes from #2236, please review it before this one
Needs releases with:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.