Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: first Screenshot taken in the app is sometimes black #2244

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

first Screenshot taken in the app is sometimes black

Solutions

before the sync of feature config is complete, the default value for screen censoring is true so now we switch it to false and it is fixed

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Unit Test Results

   474 files  +  41     474 suites  +41   2m 35s ⏱️ + 2m 10s
2 641 tests +194  2 537 ✔️ +168  104 💤 +26  0 ±0 

Results for commit 0cc1e7e. ± Comparison against base commit d7d5a72.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 21, 2023

Datadog Report

All test runs 0461b20 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1832 30 11.09s Link
kalium-jvm 0 0 0 2513 52 6m 23.02s Link

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Merging #2244 (0cc1e7e) into develop (d7d5a72) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2244   +/-   ##
==========================================
  Coverage      57.95%   57.95%           
  Complexity        21       21           
==========================================
  Files           1080     1080           
  Lines          41002    41002           
  Branches        3793     3793           
==========================================
+ Hits           23762    23764    +2     
+ Misses         15618    15617    -1     
+ Partials        1622     1621    -1     
Files Coverage Δ
...nsoring/ObserveScreenshotCensoringConfigUseCase.kt 88.88% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d5a72...0cc1e7e. Read the comment docs.

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@ohassine ohassine added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@ohassine ohassine enabled auto-merge November 22, 2023 10:51
@ohassine ohassine added this pull request to the merge queue Nov 23, 2023
Merged via the queue into develop with commit 6ca579b Nov 23, 2023
15 checks passed
@ohassine ohassine deleted the fix/first-Screenshot-taken-in-the-app-is-sometimes-black branch November 23, 2023 01:36
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
* fix: first Screenshot taken in the app is sometimes black

* edit tests

---------

Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants