-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: first Screenshot taken in the app is sometimes black #2244
fix: first Screenshot taken in the app is sometimes black #2244
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2244 +/- ##
==========================================
Coverage 57.95% 57.95%
Complexity 21 21
==========================================
Files 1080 1080
Lines 41002 41002
Branches 3793 3793
==========================================
+ Hits 23762 23764 +2
+ Misses 15618 15617 -1
+ Partials 1622 1621 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* fix: first Screenshot taken in the app is sometimes black * edit tests --------- Co-authored-by: Oussama Hassine <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
first Screenshot taken in the app is sometimes black
Solutions
before the sync of feature config is complete, the default value for screen censoring is true so now we switch it to false and it is fixed
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.