Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CC): upgrade cc to rc.18 (WPB-5431) #2246

Merged
merged 2 commits into from
Nov 23, 2023
Merged

chore(CC): upgrade cc to rc.18 (WPB-5431) #2246

merged 2 commits into from
Nov 23, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Upgrade CoreCrypto to 1.0.0-rc.18 to fix the schema migration fixes.

Issues

Fix the db schema migration issue.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 23, 2023 •
edited
Loading

Unit Test Results

   448 files   -   27     448 suites   - 27   19s ⏱️ - 2m 10s
2 533 tests  - 117  2 414 ✔️  - 132  119 💤 +15  0 ❌ ±0 

Results for commit 7a001a0. ± Comparison against base commit 7893659.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 23, 2023
Merged via the queue into develop with commit 3d10ef9 Nov 23, 2023
15 checks passed
@MohamadJaara MohamadJaara deleted the chore/rc/update-cc-rc18-cherry-pick branch November 23, 2023 02:06
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
@github-actions @mchenani
@saleniuk @augustocdias
chore(CC): upgrade cc to rc.18 (#2245) (#2246)
d507918 
Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohassine ohassine ohassine approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

Assignees

@mchenani mchenani

Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: XS type: chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yamilmedina @ohassine @MohamadJaara @mchenani @saleniuk