chore: asset not found download status [WPB-4989] #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garzas
requested review from
yamilmedina,
alexandreferris,
MohamadJaara and
saleniuk
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2250 +/- ##
=============================================
- Coverage 57.93% 57.92% -0.02%
Complexity 21 21
=============================================
Files 1084 1084
Lines 41084 41093 +9
Branches 3801 3804 +3
=============================================
+ Hits 23803 23804 +1
- Misses 15657 15662 +5
- Partials 1624 1627 +3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
yamilmedina
approved these changes
Nov 23, 2023
| @@ -116,7 +118,15 @@ internal class GetMessageAssetUseCaseImpl( | |||
| ).fold({ | |||
| kaliumLogger.e("There was an error downloading asset with id => ${assetMetadata.assetKey.obfuscateId()}") | |||
| // This should be called if there is an issue while downloading the asset | |||
| updateAssetMessageDownloadStatus(Message.DownloadStatus.FAILED_DOWNLOAD, conversationId, messageId) | |||
| if (it is NetworkFailure.ServerMiscommunication && | |||
There was a problem hiding this comment.
There is a CoreFailure.isInvalidRequestError helper, we might use I think
saleniuk
reviewed
Nov 23, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/asset/GetMessageAssetUseCase.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/asset/GetMessageAssetUseCase.kt
Outdated
Show resolved
Hide resolved
MohamadJaara
approved these changes
Nov 23, 2023
saleniuk
approved these changes
Nov 23, 2023
augustocdias
pushed a commit
that referenced
this pull request
Dec 5, 2023
* chore: asset not found download status * review fixes * test fix
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?