Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create observer for legal hold state (WPB-5442) #2251

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

This PR aims to create two use cases to observe legal hold state of a other user or current one.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution
  • [ ]

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Unit Test Results

   348 files   - 128     348 suites   - 128   11s ⏱️ - 2m 12s
1 878 tests  - 775  1 848 ✔️  - 701  30 💤  - 74  0 ±0 

Results for commit 4ac4b31. ± Comparison against base commit 8ee46ea.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

All test runs 680e24c 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1844 30 13.12s Link
kalium-jvm 0 0 0 2551 104 7m 13.05s Link

…r_legal_hold_state

# Conflicts:
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
@ohassine ohassine enabled auto-merge November 24, 2023 09:13
@ohassine ohassine added this pull request to the merge queue Nov 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2251 (4ac4b31) into develop (8ee46ea) will increase coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 94.44%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2251      +/-   ##
=============================================
+ Coverage      57.92%   57.94%   +0.01%     
  Complexity        21       21              
=============================================
  Files           1084     1086       +2     
  Lines          41093    41106      +13     
  Branches        3804     3804              
=============================================
+ Hits           23804    23819      +15     
+ Misses         15662    15661       -1     
+ Partials        1627     1626       -1     
Files Coverage Δ
...re/legalhold/ObserveLegalHoldForSelfUserUseCase.kt 100.00% <100.00%> (ø)
...e/legalhold/ObserveLegalHoldStateForUserUseCase.kt 100.00% <100.00%> (ø)
...eature/legalhold/ObserveLegalHoldRequestUseCase.kt 61.53% <80.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee46ea...4ac4b31. Read the comment docs.

Merged via the queue into develop with commit d9df432 Nov 24, 2023
17 checks passed
@ohassine ohassine deleted the create_observer_for_legal_hold_state branch November 24, 2023 10:17
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
* feat: Create observer for legal hold state

* chore: rename use case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants