refactor: remove the fetch of full team members during slow sync #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
type: refactoring 🛠
👕 size: M
labels
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2253 +/- ##
=============================================
- Coverage 57.94% 57.93% -0.01%
Complexity 21 21
=============================================
Files 1082 1082
Lines 41053 41036 -17
Branches 3798 3796 -2
=============================================
- Hits 23789 23776 -13
+ Misses 15640 15638 -2
+ Partials 1624 1622 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
MohamadJaara
requested review from
alexandreferris,
vitorhugods,
yamilmedina and
mchenani
alexandreferris
approved these changes
Nov 23, 2023
…-all-team-members
MohamadJaara
commented
Nov 23, 2023
| teamRepository.fetchTeamById(teamId = teamId) | ||
| .map { } | ||
| .onSuccess { | ||
| teamRepository.syncServices(teamId = teamId) |
There was a problem hiding this comment.
we still need to fetch the full list of services since those are not included in search result
saleniuk
approved these changes
Nov 24, 2023
MohamadJaara
deleted the
refactor/stop-maintaining-a-local-list-of-all-team-members
branch
augustocdias
pushed a commit
that referenced
this pull request
Dec 5, 2023
* refactor: remove the fetch of full team members during slow sync * detekt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
we don not need to maintain a full list of team members
Solutions
nuke any mention to fetching a full list of team members
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.