-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove unused legacy ClientDTO values (WPB-5623) #2254
Merged
MohamadJaara
merged 2 commits into
release/candidate
from
refactor/nuke-unused-legacy-client-locaion
Nov 23, 2023
Merged
refactor: remove unused legacy ClientDTO values (WPB-5623) #2254
MohamadJaara
merged 2 commits into
release/candidate
from
refactor/nuke-unused-legacy-client-locaion
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamadJaara
requested review from
a team,
typfel,
yamilmedina,
alexandreferris,
vitorhugods and
ohassine
and removed request for
a team
November 23, 2023 10:58
tmspzz
approved these changes
Nov 23, 2023
alexandreferris
approved these changes
Nov 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2254 +/- ##
====================================================
Coverage ? 58.05%
Complexity ? 21
====================================================
Files ? 1073
Lines ? 40760
Branches ? 3776
====================================================
Hits ? 23665
Misses ? 15475
Partials ? 1620 Continue to review full report in Codecov by Sentry.
|
8 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
* refactor: remove unused legacy ClientDTO values * adjust tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2023
* refactor: remove unused legacy ClientDTO values * adjust tests Co-authored-by: Mohamad Jaara <[email protected]>
MohamadJaara
changed the title
refactor: remove unused legacy ClientDTO values
refactor: remove unused legacy ClientDTO values (WPB-5623)
Nov 29, 2023
augustocdias
pushed a commit
that referenced
this pull request
Dec 5, 2023
* refactor: remove unused legacy ClientDTO values * adjust tests Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
there are some legacy values in the client DTO response that are not used by the app
Solutions
nuke em all
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.