Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused legacy ClientDTO values (WPB-5623) #2254

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

there are some legacy values in the client DTO response that are not used by the app

Solutions

nuke em all

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Unit Test Results

   439 files     439 suites   23s ⏱️
2 487 tests 2 384 ✔️ 103 💤 0

Results for commit 713a283.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara enabled auto-merge (squash) November 23, 2023 11:25
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@83763fb). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2254   +/-   ##
====================================================
  Coverage                     ?   58.05%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1073           
  Lines                        ?    40760           
  Branches                     ?     3776           
====================================================
  Hits                         ?    23665           
  Misses                       ?    15475           
  Partials                     ?     1620           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83763fb...713a283. Read the comment docs.

@MohamadJaara MohamadJaara merged commit 460a84a into release/candidate Nov 23, 2023
17 checks passed
@MohamadJaara MohamadJaara deleted the refactor/nuke-unused-legacy-client-locaion branch November 23, 2023 11:31
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
* refactor: remove unused legacy ClientDTO values

* adjust tests
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2023
* refactor: remove unused legacy ClientDTO values

* adjust tests

Co-authored-by: Mohamad Jaara <[email protected]>
@MohamadJaara MohamadJaara changed the title refactor: remove unused legacy ClientDTO values refactor: remove unused legacy ClientDTO values (WPB-5623) Nov 29, 2023
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
* refactor: remove unused legacy ClientDTO values

* adjust tests

Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants