Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump AVS to 9.5.6 to remove nearby devices permission (WPB-4583) #2257

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 23, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

What's new

  • No need to request nearby devices permission to make calls
  • Some audio routing improvements

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Unit Test Results

   449 files   -   27     449 suites   - 27   20s ⏱️ - 2m 9s
2 536 tests  - 117  2 417 ✔️  - 132  119 💤 +15  0 ±0 

Results for commit fb6a615. ± Comparison against base commit 6d61603.

♻️ This comment has been updated with latest results.

@ohassine ohassine added this pull request to the merge queue Nov 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2023
@ohassine ohassine enabled auto-merge November 24, 2023 08:03
@codecov-commenter
Copy link

Codecov Report

Merging #2257 (fb6a615) into develop (6d61603) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2257   +/-   ##
==========================================
  Coverage      57.92%   57.92%           
  Complexity        21       21           
==========================================
  Files           1084     1084           
  Lines          41093    41093           
  Branches        3804     3804           
==========================================
+ Hits           23804    23805    +1     
+ Misses         15662    15661    -1     
  Partials        1627     1627           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d61603...fb6a615. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 24, 2023

Datadog Report

All test runs 722dd9c 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2417 119 7m 41.09s Link
kalium-jvm 0 0 0 2549 104 7m 9.05s Link

@ohassine ohassine added this pull request to the merge queue Nov 24, 2023
Merged via the queue into develop with commit 8ee46ea Nov 24, 2023
17 checks passed
@ohassine ohassine deleted the bump_avs_version branch November 24, 2023 08:56
MohamadJaara added a commit that referenced this pull request Nov 24, 2023
github-merge-queue bot pushed a commit that referenced this pull request Nov 27, 2023
* Revert "feat: bump AVS to 9.5.6 (#2257)"

This reverts commit 8ee46ea.

* set avs version to 9.5.7
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
* Revert "feat: bump AVS to 9.5.6 (#2257)"

This reverts commit 8ee46ea.

* set avs version to 9.5.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants