-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mark user as deleted when server response with 404 #2259
feat: mark user as deleted when server response with 404 #2259
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2259 +/- ##
=============================================
- Coverage 57.93% 57.92% -0.02%
Complexity 21 21
=============================================
Files 1084 1084
Lines 41084 41090 +6
Branches 3801 3804 +3
=============================================
- Hits 23803 23802 -1
- Misses 15657 15659 +2
- Partials 1624 1629 +5
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
…)" This reverts commit 66585d1.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
to be able to stop maintaining a full list of team members, we need to mark users as deleted when the server response with 404
Solutions
mark users as deleted when server response with 404
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.