Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark user as deleted when server response with 404 #2259

Merged

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Nov 23, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

to be able to stop maintaining a full list of team members, we need to mark users as deleted when the server response with 404

Solutions

mark users as deleted when server response with 404

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Unit Test Results

   346 files   - 130     346 suites   - 130   9s ⏱️ - 2m 35s
1 873 tests  - 780  1 843 ✔️  - 706  30 💤  - 74  0 ±0 

Results for commit 01d19fa. ± Comparison against base commit 23be862.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #2259 (01d19fa) into develop (23be862) will decrease coverage by 0.02%.
The diff coverage is 37.50%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2259      +/-   ##
=============================================
- Coverage      57.93%   57.92%   -0.02%     
  Complexity        21       21              
=============================================
  Files           1084     1084              
  Lines          41084    41090       +6     
  Branches        3801     3804       +3     
=============================================
- Hits           23803    23802       -1     
- Misses         15657    15659       +2     
- Partials        1624     1629       +5     
Files Coverage Δ
.../com/wire/kalium/logic/data/user/UserRepository.kt 65.18% <37.50%> (-0.35%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23be862...01d19fa. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 23, 2023

Datadog Report

All test runs 9602d3c 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1843 30 10.1s Link
kalium-jvm 0 0 0 2550 104 7m 13.04s Link

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 24, 2023
Merged via the queue into develop with commit 66585d1 Nov 24, 2023
20 checks passed
@MohamadJaara MohamadJaara deleted the feat/mark-user-as-deleted-when-server-response-with-404 branch November 24, 2023 09:29
MohamadJaara added a commit that referenced this pull request Nov 25, 2023
github-merge-queue bot pushed a commit that referenced this pull request Nov 29, 2023
…2265)

* Revert "feat: mark user as deleted when server response with 404 (#2259)"

This reverts commit 66585d1.

* Empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants