Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: avs 9.5.6 version and remove of permissions #2264

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

revert avs version update and set the version to match the one on RC

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 24, 2023

Unit Test Results

   451 files   -   27     451 suites   - 27   21s ⏱️ - 2m 9s
2 543 tests  - 117  2 424 ✔️  - 132  119 💤 +15  0 ±0 

Results for commit d256bd0. ± Comparison against base commit f7a8ad1.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #2264 (d256bd0) into develop (f7a8ad1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2264   +/-   ##
==========================================
  Coverage      57.92%   57.92%           
  Complexity        21       21           
==========================================
  Files           1086     1086           
  Lines          41096    41096           
  Branches        3806     3806           
==========================================
  Hits           23806    23806           
  Misses         15660    15660           
  Partials        1630     1630           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a8ad1...d256bd0. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 24, 2023

Datadog Report

All test runs f88c710 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2424 119 7m 8.09s Link
kalium-jvm 0 0 0 2556 104 7m 11.05s Link

@ohassine ohassine added this pull request to the merge queue Nov 27, 2023
Merged via the queue into develop with commit 525a2d7 Nov 27, 2023
16 checks passed
@ohassine ohassine deleted the revert/avs-update branch November 27, 2023 10:06
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
* Revert "feat: bump AVS to 9.5.6 (#2257)"

This reverts commit 8ee46ea.

* set avs version to 9.5.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants