-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: mark user as deleted when server response with 404 (#2259) #2265
Conversation
…)" This reverts commit 66585d1.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2265 +/- ##
==========================================
Coverage 57.92% 57.93%
Complexity 21 21
==========================================
Files 1086 1085 -1
Lines 41096 41087 -9
Branches 3806 3803 -3
==========================================
- Hits 23806 23802 -4
- Misses 15660 15661 +1
+ Partials 1630 1624 -6
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
2f535d6
to
d08eff1
Compare
…59)"
This reverts commit 66585d1.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
after discussing this feature with int the team it is not required, and the use case is updated
Solutions
revert the change
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.