Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: mark user as deleted when server response with 404 (#2259) #2265

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

MohamadJaara
Copy link
Member

…59)"

This reverts commit 66585d1.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

after discussing this feature with int the team it is not required, and the use case is updated

Solutions

revert the change

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 25, 2023

Unit Test Results

       1 files   - 477         1 suites   - 477   8s ⏱️ - 2m 20s
1 875 tests  - 785  1 870 ✔️  - 686  5 💤  - 99  0 ±0 

Results for commit 5097b1c. ± Comparison against base commit ecf25d0.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

Merging #2265 (5097b1c) into develop (f7a8ad1) will increase coverage by 0.00%.
Report is 4 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2265   +/-   ##
==========================================
  Coverage      57.92%   57.93%           
  Complexity        21       21           
==========================================
  Files           1086     1085    -1     
  Lines          41096    41087    -9     
  Branches        3806     3803    -3     
==========================================
- Hits           23806    23802    -4     
- Misses         15660    15661    +1     
+ Partials        1630     1624    -6     
Files Coverage Δ
.../com/wire/kalium/logic/data/user/UserRepository.kt 65.53% <0.00%> (+0.34%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a8ad1...5097b1c. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 26, 2023

Datadog Report

All test runs b684b53 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1848 30 9.09s Link
kalium-jvm 0 0 0 2555 104 7m 20.06s Link

@MohamadJaara MohamadJaara changed the title revert: "feat: mark user as deleted when server response with 404 (#22… revert: feat: mark user as deleted when server response with 404 (#2259) Nov 26, 2023
@MohamadJaara MohamadJaara changed the title revert: feat: mark user as deleted when server response with 404 (#2259) revert: mark user as deleted when server response with 404 (#2259) Nov 27, 2023
@MohamadJaara MohamadJaara force-pushed the revert/mark-users-as-deleted-on-404 branch from 2f535d6 to d08eff1 Compare November 27, 2023 08:54
@MohamadJaara MohamadJaara requested review from a team, yamilmedina, borichellow, mchenani, ohassine and saleniuk and removed request for a team November 27, 2023 09:43
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 29, 2023
Merged via the queue into develop with commit efcf764 Nov 29, 2023
17 checks passed
@MohamadJaara MohamadJaara deleted the revert/mark-users-as-deleted-on-404 branch November 29, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants