refactor: update the list of users ID when adding a new members fails with 403

[MohamadJaara]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

we need to stop maintaining a full list of team members.

Solutions

when adding a new member to a conversation and it fail with 403 we need to update the list of users the we tried to add to make sure nothing is deleted

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Unit Test Results

       1 files   - 478         1 suites   - 478   9s ⏱️ - 2m 47s
1 887 tests  - 784  1 882 ✔️  - 685  5 💤  - 99  0 ❌ ±0 

Results for commit d85264f. ± Comparison against base commit 7600fa8.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

Merging #2267 (d85264f) into develop (7600fa8) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2267   +/-   ##
==========================================
  Coverage      58.08%   58.09%           
  Complexity        21       21           
==========================================
  Files           1087     1087           
  Lines          41147    41156    +9     
  Branches        3808     3811    +3     
==========================================
+ Hits           23901    23910    +9     
+ Misses         15618    15615    -3     
- Partials        1628     1631    +3     

Files	Coverage Δ
.../com/wire/kalium/logic/data/user/UserRepository.kt	65.18% <ø> (ø)
...um/logic/feature/conversation/ConversationScope.kt	0.00% <0.00%> (ø)
...ure/conversation/AddMemberToConversationUseCase.kt	88.88% <85.71%> (-11.12%)	⬇️

... and 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7600fa8...d85264f. Read the comment docs.

[datadog-wireapp]

Datadog Report

All test runs cea9598 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Branch View
kalium-ios	0	0	0	1860	30	14.11s	Link
kalium-jvm	0	0	0	2568	104	9m 28.04s	Link

[yamilmedina]

LGTM! Just a small comment that we can have to make it more clear about the empty else block