fix(jvm): support logout and login when using in-memory storage #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the logic and structure for handling file-related operations in storageData. Added Support for both file-backed and in-memory databases in the userDatabaseBuilder. Also introduced the InMemoryDatabaseCache to hold a database across logins/ logouts without losing the data.
vitorhugods
requested review from
augustocdias,
a team,
typfel,
yamilmedina,
alexandreferris,
borichellow and
saleniuk
and removed request for
a team
augustocdias
approved these changes
Nov 28, 2023
MohamadJaara
approved these changes
Nov 28, 2023
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2274 +/- ##
=============================================
- Coverage 58.08% 58.08% -0.01%
Complexity 21 21
=============================================
Files 1086 1087 +1
Lines 41144 41147 +3
Branches 3808 3808
=============================================
+ Hits 23898 23899 +1
- Misses 15618 15619 +1
- Partials 1628 1629 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
vitorhugods
deleted the
fix/jvm/support-logout-and-login-when-using-in-memory-storage
branch
4 tasks
augustocdias
pushed a commit
that referenced
this pull request
Dec 5, 2023
* fix(jvm): support logout and login when using in-memory storage Updated the logic and structure for handling file-related operations in storageData. Added Support for both file-backed and in-memory databases in the userDatabaseBuilder. Also introduced the InMemoryDatabaseCache to hold a database across logins/ logouts without losing the data. * style: unify inMemoryDatabase cleaning * style: remove duplicate blank line * chore: fix missing constructor call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When using
inMemoryStoragefor JVM, it's impossible to logout and then login again, as a new instance will be created from scratch, even when usingSELF_SOFT_LOGOUTLogoutReason.Solutions
Introduced the
InMemoryDatabaseCacheto hold a database across logins/logouts without losing the data.If
nukeis called, this cache will be cleared too. Which should only happen when there's a hard logout.Make sure we also clear the cache when running unit tests.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.