feat: handle federation context for MLS add participants to a conversation (WPB-2229) #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
yamilmedina
requested review from
typfel,
a team,
alexandreferris,
MohamadJaara,
mchenani and
Garzas
and removed request for
a team
mchenani
approved these changes
Dec 4, 2023
| groupId: String, | ||
| userIdList: List<UserId>, | ||
| failedUsersList: Set<UserId> = emptySet(), | ||
| remainingAttempts: Int = 2 |
There was a problem hiding this comment.
suggestion: can we extract this default value to the top of the class for example?
typfel
requested changes
Dec 5, 2023
...src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationGroupRepository.kt
Outdated
Show resolved
Hide resolved
typfel
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
No special handling for federated environments for adding participants in an MLS conversation.
Causes (Optional)
Not implemented.
Solutions
Handle retry mechanism, when claiming packages fails due to:
Handle retry mechanism, when post commit bundle fails due to:
Reusing some of the prev work like
RetryableFailure, System messages creator to name a few.Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.