feat: Add pagination in searched messages result screen (WPB-5498) #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreferris
changed the title
MohamadJaara
approved these changes
Nov 29, 2023
alexandreferris
requested review from
a team,
typfel,
yamilmedina,
borichellow,
ohassine,
saleniuk and
Garzas
and removed request for
a team
yamilmedina
approved these changes
Nov 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
6 tasks
MohamadJaara
pushed a commit
that referenced
this pull request
Nov 30, 2023
…2277) * feat: add db query change and repository for paginating result * feat: return empty list of normal message for now * feat: add paginated data usecase and its repository extension * feat: remove unnecessary messageId from pagination as it was needed for count * feat: remove unused functions for db query * chore: adjust detekt * test: remove existing and add new tests * chore: remove unused usecase, repository and tests
MohamadJaara
pushed a commit
that referenced
this pull request
Dec 1, 2023
…2277) * feat: add db query change and repository for paginating result * feat: return empty list of normal message for now * feat: add paginated data usecase and its repository extension * feat: remove unnecessary messageId from pagination as it was needed for count * feat: remove unused functions for db query * chore: adjust detekt * test: remove existing and add new tests * chore: remove unused usecase, repository and tests
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
There was a bit of a performance issue when search result was extensive.
Solutions
Added pagination to search result (now its so blazing fast that sometimes the loading icon doesn't even show 😢 )
Testing
Test Coverage (Optional)
How to Test
AR PR will follow and it will be able to test the feature there.
Notes (Optional)