feat: Update legal hold status on message receive (WPB-5442) #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation_table' into add_legal_hold_status_to_conversation_table
…clude_legal_hold_flag
…ation_table' into include_legal_hold_flag
…_flag # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/Conversation.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/web/WebMappers.kt
…clude_legal_hold_flag
This reverts commit ef75642.
ohassine
requested review from
a team,
typfel,
alexandreferris,
MohamadJaara,
mchenani and
saleniuk
and removed request for
a team
Test Results1 901 tests - 793 1 896 ✔️ - 694 10s ⏱️ - 2m 39s Results for commit 47508c9. ± Comparison against base commit ab83fea. This pull request removes 2694 and adds 1901 tests. Note that renamed tests count towards both.This pull request removes 104 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2286 +/- ##
=============================================
+ Coverage 58.35% 58.37% +0.01%
Complexity 21 21
=============================================
Files 1094 1094
Lines 41756 41764 +8
Branches 3881 3881
=============================================
+ Hits 24368 24380 +12
+ Misses 15749 15746 -3
+ Partials 1639 1638 -1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
This was referenced Dec 5, 2023
# Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/ProtoContentMapper.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/receiver/conversation/message/NewMessageEventHandler.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/message/NewMessageEventHandlerTest.kt
saleniuk
approved these changes
Dec 8, 2023
ohassine
requested review from
a team,
yamilmedina and
vitorhugods
and removed request for
a team
alexandreferris
approved these changes
Dec 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description
When we receive a new message, we need to get the legal hold status and update the conversation with this new value
#2279 needs to be reviewed before this one as there is some changes from it here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.