-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update out of sync conversation info when sending messages fails #2288
Merged
MohamadJaara
merged 3 commits into
develop
from
feat/update-conversation-info-when-out-of-sync
Dec 7, 2023
Merged
feat: update out of sync conversation info when sending messages fails #2288
MohamadJaara
merged 3 commits into
develop
from
feat/update-conversation-info-when-out-of-sync
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 898 tests - 784 1 868 ✔️ - 710 9s ⏱️ - 2m 9s Results for commit 082418f. ± Comparison against base commit 1ad916c. This pull request removes 2682 and adds 1898 tests. Note that renamed tests count towards both.
This pull request removes 104 skipped tests and adds 30 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
MohamadJaara
requested review from
yamilmedina,
Garzas,
saleniuk,
a team,
vitorhugods and
ohassine
and removed request for
a team
December 6, 2023 08:40
alexandreferris
approved these changes
Dec 6, 2023
yamilmedina
approved these changes
Dec 6, 2023
MohamadJaara
deleted the
feat/update-conversation-info-when-out-of-sync
branch
December 7, 2023 10:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
error loop when sending a message in an out of sync conversation
Solutions
update conversation members when we get out of sync error
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.