-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create legal hold system messages [WPB-4779] #2291
Conversation
…-hold-system-messages # Conflicts: # persistence/src/commonMain/db_user/migrations/66.sqm
…-hold-system-messages # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageRepository.kt # persistence/src/commonMain/db_user/migrations/67.sqm
…-hold-system-messages
Test Results2 358 tests - 344 2 292 ✔️ - 306 28s ⏱️ - 2m 5s Results for commit 3d9f661. ± Comparison against base commit b5f15cb. This pull request removes 2702 and adds 2358 tests. Note that renamed tests count towards both.
This pull request removes 104 skipped tests and adds 66 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2291 +/- ##
=============================================
- Coverage 58.66% 58.57% -0.09%
Complexity 21 21
=============================================
Files 1097 1100 +3
Lines 41809 42259 +450
Branches 3884 3954 +70
=============================================
+ Hits 24526 24752 +226
- Misses 15618 15751 +133
- Partials 1665 1756 +91
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/Message.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/com/wire/kalium/logic/feature/conversation/MembersHavingLegalHoldClientUseCase.kt
Outdated
Show resolved
Hide resolved
.../commonMain/kotlin/com/wire/kalium/logic/sync/receiver/handler/legalhold/LegalHoldHandler.kt
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Messages.sq
Show resolved
Hide resolved
…-hold-system-messages # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/PersistMessageUseCase.kt # persistence/src/commonMain/db_user/com/wire/kalium/persistence/MessageDetailsView.sq # persistence/src/commonMain/db_user/com/wire/kalium/persistence/Messages.sq # persistence/src/commonMain/db_user/migrations/68.sqm # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageEntity.kt # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageInsertExtension.kt # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageMapper.kt # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/db/TableMapper.kt # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/db/UserDatabaseBuilder.kt # persistence/src/commonTest/kotlin/com/wire/kalium/persistence/dao/message/MessageMapperTest.kt
…-hold-system-messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Testing
Test Coverage (Optional)
How to Test
Enable or disable legal hold for a team member to see system messages.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.