fix: cert pinning failing for GET:/api-version #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
cherry-pick
MohamadJaara
approved these changes
Dec 13, 2023
alexandreferris
approved these changes
Dec 13, 2023
…cherry-pick # Conflicts: # network/src/commonJvmAndroid/kotlin/com/wire/kalium/network/HttpEngine.kt
Test Results2 121 tests - 626 2 114 ✔️ - 529 14s ⏱️ - 2m 40s Results for commit 9896cb8. ± Comparison against base commit 568fde8. This pull request removes 2747 and adds 2121 tests. Note that renamed tests count towards both.This pull request removes 104 skipped tests and adds 7 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2302 +/- ##
=============================================
- Coverage 58.58% 58.58% -0.01%
Complexity 21 21
=============================================
Files 1102 1102
Lines 42293 42293
Branches 3957 3957
=============================================
- Hits 24778 24777 -1
- Misses 15760 15761 +1
Partials 1755 1755
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alexandreferris
deleted the
fix/cert-pnning-for-api-version-endpoint-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
cert pinning failing for GET:/api-version only
Solutions
there is a flag to ignore ssl cert in unbound network client for e2ei and that flag should be true only in debug mode and it was not, it should not have effected any users in prod
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References