refactor: create a new okhttp client for each user on jvm target #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamadJaara
requested review from
mythsunwind,
yamilmedina,
a team,
typfel,
alexandreferris and
borichellow
and removed request for
a team
yamilmedina
approved these changes
Dec 11, 2023
Test Results2 088 tests - 606 2 046 ✔️ - 544 10s ⏱️ - 2m 39s Results for commit 6b6c5dc. ± Comparison against base commit ab83fea. This pull request removes 2694 and adds 2088 tests. Note that renamed tests count towards both.This pull request removes 104 skipped tests and adds 42 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
MohamadJaara
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2304 +/- ##
=============================================
+ Coverage 58.35% 58.65% +0.30%
Complexity 21 21
=============================================
Files 1094 1097 +3
Lines 41756 41809 +53
Branches 3881 3884 +3
=============================================
+ Hits 24367 24525 +158
+ Misses 15751 15619 -132
- Partials 1638 1665 +27 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
alexandreferris
approved these changes
Dec 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MohamadJaara
deleted the
fix/create-a-new-okhttp-client-for-each-user-on-jvm-target
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
test services are limited on the number of web socket connection that can be created
Solutions
it was solved temporary by reverting the commit only for the test service branch, but now this is a permanent fix, that refactor the way Okhttp client are created bu using a Singleton in Android and createing a new one each time on jvm
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.