Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monkeys): Add support for multi-clients in the replay mode [WPB-5764] #2309

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

augustocdias
Copy link


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adds support for storing which client was responsible for executing the event and in replay it will split the events per client.

Also removing the kalium cache folder for the tests. This is helpful if we reuse the same users for further executions.


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Test Results

2 747 tests  ±0   2 643 ✔️ ±0   2m 50s ⏱️ -4s
   485 suites ±0      104 💤 ±0 
   485 files   ±0          0 ±0 

Results for commit 4416ba7. ± Comparison against base commit 568fde8.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/monkeys/multi-cli-replay
Commit report: 68102e1

kalium-jvm: 0 Failed, 0 New Flaky, 2643 Passed, 104 Skipped, 7m 53.04s Wall Time

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustocdias augustocdias added this pull request to the merge queue Jan 10, 2024
Merged via the queue into develop with commit 0696b8e Jan 10, 2024
17 checks passed
@augustocdias augustocdias deleted the feat/monkeys/multi-cli-replay branch January 10, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants