fix: E2EI required: grace period in seconds (WPB-5771) #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
borichellow
commented
Dec 15, 2023
| @@ -458,7 +458,7 @@ class UserConfigStorageImpl( | |||
| E2EI_NOTIFICATION_TIME, | |||
| timeStamp | |||
| ).also { | |||
| e2EIFlow.tryEmit(Unit) | |||
| e2EINotificationFlow.tryEmit(Unit) | |||
There was a problem hiding this comment.
this doesn't relate to the original task, i just found some copy-past mistake (which causes unknown yet issue) and fixed it :)
mchenani
approved these changes
Dec 15, 2023
ohassine
approved these changes
Dec 15, 2023
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
in
E2EIConfigAPI response we were expecting that fieldverificationExpirationis timestamp of the end of the grace period in nano-seconds. In fact it's amount of seconds that left till the end of grace period (stating from the moment when we receive that info). So needed to updateE2EIConfigHandlerCauses (Optional)
It wasn't documented well.
Solutions
Update
E2EIConfigHandlerand tests.