-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: notify user when sending first message in conversation on legal hold [WPB-4566] #2315
feat: notify user when sending first message in conversation on legal hold [WPB-4566] #2315
Conversation
…legal-hold-when-sending-msg
Test Results2 408 tests - 362 2 342 ✔️ - 324 25s ⏱️ - 2m 39s Results for commit 0116895. ± Comparison against base commit edccb70. This pull request removes 2770 and adds 2408 tests. Note that renamed tests count towards both.
This pull request removes 104 skipped tests and adds 66 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Conversations.sq
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2315 +/- ##
=============================================
+ Coverage 58.53% 58.66% +0.13%
Complexity 21 21
=============================================
Files 1103 1106 +3
Lines 42459 42579 +120
Branches 3980 3986 +6
=============================================
+ Hits 24853 24980 +127
+ Misses 15841 15830 -11
- Partials 1765 1769 +4
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…legal-hold-when-sending-msg # Conflicts: # persistence/src/commonMain/db_user/migrations/70.sqm
...m/wire/kalium/logic/feature/conversation/ObserveConversationUnderLegalHoldNotifiedUseCase.kt
Outdated
Show resolved
Hide resolved
…legal-hold-when-sending-msg
…legal-hold-when-sending-msg # Conflicts: # persistence/src/commonMain/db_user/migrations/71.sqm # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/db/UserDatabaseBuilder.kt
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
When user opens a conversation with a team member on legal hold and wants to send first message after this conversation became subject to legal hold then he/she needs to be informed about that.
Added new column to the table and created two use cases to observe and update the flag informing whether the user is already informed about the legal hold status change.
Testing
Test Coverage (Optional)
How to Test
Enable legal hold for one member and try to send a message.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.