feat: Indicate user with valid E2EI certificate (WPB-3228) #2335

borichellow · 2023-12-28T10:12:16Z

What's new in this PR?

Issues

No way to get users E2EI certificate status (only for each client separately)

Causes (Optional)

Was not implemented

Solutions

Added 2 useCases:

For getting users E2EI certificate status by UserId ( GetUserE2eiCertificateStatusUseCase )
For getting users E2EI certificate status for all the users in conversation, by ConversationId ( GetMembersE2EICertificateStatusesUseCase )

And Tests for these UseCases

…icate

github-actions · 2023-12-28T14:04:35Z

Test Results

2 452 tests - 366 2 385 ✔️ - 329 32s ⏱️ - 2m 28s
  410 suites -   81     67 💤 -   37
  410 files -   81       0 ❌ ±    0

Results for commit 4fb1908. ± Comparison against base commit 0696b8e.

This pull request removes 2818 and adds 2452 tests. Note that renamed tests count towards both.

PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenTheHttpClientIsCreated_ThenEnsureOnlySupportedSpecsArePresent[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithAccessRoleAndDeprecatedAccessRoleField_whenDecoding_thenDeprecatedFieldIsPreferred[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithDeprecatedAccessRoleField_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayload_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoLocationInHeader_whenCallingSendAcmeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoNonce_whenCallingSendAcmeRequestApi_theResponseShouldBeMissingNonce[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGetACMEDirectoriesApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGetACMENonceApi_theResponseShouldBeConfigureCorrectly[jvm]
…

com.wire.kalium.logic.cache.SelfConversationIdProviderTest ‑ givenFailure_thenErrorIsPropagated[iosX64]
com.wire.kalium.logic.cache.SelfConversationIdProviderTest ‑ givenMLSClientHasBeenRegistered_thenMLSAndProteusSelfConversationAreReturned[iosX64]
com.wire.kalium.logic.cache.SelfConversationIdProviderTest ‑ givenMLSClientHasNotBeenRegistered_thenProteusSelfConversationIsReturned[iosX64]
com.wire.kalium.logic.client.E2EIClientProviderTest ‑ givenMLSClientWithE2EI_whenGettingE2EIClient_callsNewActivationEnrollment[iosX64]
com.wire.kalium.logic.client.E2EIClientProviderTest ‑ givenMLSClientWithoutE2EI_whenGettingE2EIClient_callsNewRotateEnrollment[iosX64]
com.wire.kalium.logic.client.E2EIClientProviderTest ‑ givenSelfUserNotFound_whenGettingE2EIClient_ReturnsError[iosX64]
com.wire.kalium.logic.configuration.ServerConfigMapperTest ‑ givenACommonApiVersion_whenMapping_thenValuesAreMappedCorrectly[iosX64]
com.wire.kalium.logic.configuration.ServerConfigMapperTest ‑ givenANetworkConfigEntity_whenMappingFromNetworkConfig_thenValuesAreMappedCorrectly[iosX64]
com.wire.kalium.logic.configuration.ServerConfigMapperTest ‑ givenAServerConfig_whenMappingToBackendConfig_thenValuesAreMappedCorrectly[iosX64]
com.wire.kalium.logic.configuration.ServerConfigMapperTest ‑ givenAServerConfig_whenMappingToNetworkConfig_thenValuesAreMappedCorrectly[iosX64]
…

This pull request removes 104 skipped tests and adds 67 skipped tests. Note that renamed tests count towards both.

PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendChallengeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenActivationEmailWIthCode_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenRegisteringAccountWithEMail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenSendingActivationEmail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenActivationCodeFail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenRegistrationFail_whenRegisteringAccountWithEMMail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenSendActivationCodeFail_thenErrorIsPropagated[jvm]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenDummyText_whenEncryptedAndDecryptedWithAES256_returnsOriginalText[js, browser]
…

com.wire.kalium.logic.data.reaction.ReactionRepositoryTest ‑ givenSelfUserReactionWasPersisted_whenObservingMessageReactions_thenShouldReturnReactionsPreviouslyStored[iosX64]
com.wire.kalium.logic.feature.backup.CreateBackupUseCaseTest ‑ givenSomeInvalidDBData_whenCreatingNonEncryptedBackup_thenTheRightErrorIsThrown[iosX64]
com.wire.kalium.logic.feature.backup.CreateBackupUseCaseTest ‑ givenSomeValidData_whenCreatingAnEncryptedBackup_thenTheFinalBackupFileIsCreatedCorrectly[iosX64]
com.wire.kalium.logic.feature.backup.CreateBackupUseCaseTest ‑ givenSomeValidData_whenCreatingNonEncryptedBackup_thenTheFinalBackupFileIsCreatedCorrectly[iosX64]
com.wire.kalium.logic.feature.backup.RestoreBackupUseCaseTest ‑ givenACorrectNonEncryptedBackupFileWithWrongAuthor_whenRestoring_thenTheCorrectErrorIsThrown[iosX64]
com.wire.kalium.logic.feature.backup.RestoreBackupUseCaseTest ‑ givenACorrectNonEncryptedBackupFileWithWrongMetadataFileName_whenRestoring_thenTheCorrectErrorIsThrown[iosX64]
com.wire.kalium.logic.feature.backup.RestoreBackupUseCaseTest ‑ givenACorrectNonEncryptedBackupFile_whenRestoring_thenTheBackupIsRestoredSuccessfully[iosX64]
com.wire.kalium.logic.feature.backup.RestoreBackupUseCaseTest ‑ givenACorrectlyEncryptedBackup_whenRestoringWithADBImportError_thenTheRightErrorIsThrown[iosX64]
com.wire.kalium.logic.feature.backup.RestoreBackupUseCaseTest ‑ givenACorrectlyEncryptedBackup_whenRestoringWithWrongPassword_thenTheRightErrorIsThrown[iosX64]
com.wire.kalium.logic.feature.backup.RestoreBackupUseCaseTest ‑ givenAValidEncryptedBackupFile_whenRestoring_thenTheBackupIsRestoredCorrectly[iosX64]
…

♻️ This comment has been updated with latest results.

datadog-wireapp · 2023-12-28T14:14:54Z

Datadog Report

All test runs ac2c16c 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Test Service View
`kalium-ios`	0	0	0	2385	67	9m 11.11s	Link
`kalium-jvm`	0	0	0	2725	104	8m 43.04s	Link

...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt

persistence/src/commonMain/db_user/com/wire/kalium/persistence/Conversations.sq

codecov-commenter · 2024-01-03T19:09:49Z

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (0696b8e) 58.49% compared to head (4fb1908) 58.47%.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2335      +/-   ##
=============================================
- Coverage      58.49%   58.47%   -0.03%     
  Complexity        21       21              
=============================================
  Files           1111     1114       +3     
  Lines          43597    43705     +108     
  Branches        4077     4083       +6     
=============================================
+ Hits           25502    25555      +53     
- Misses         16286    16340      +54     
- Partials        1809     1810       +1

Files	Coverage Δ
...secase/GetMembersE2EICertificateStatusesUseCase.kt	`100.00% <100.00%> (ø)`
...ture/e2ei/usecase/GetUserE2EICertificateUseCase.kt	`100.00% <100.00%> (ø)`
...um/persistence/dao/conversation/ConversationDAO.kt	`100.00% <ø> (ø)`
...gic/data/conversation/MLSConversationRepository.kt	`85.98% <95.83%> (+0.69%)`	⬆️
...ersistence/dao/conversation/ConversationDAOImpl.kt	`64.48% <0.00%> (-2.46%)`	⬇️
...in/com/wire/kalium/logic/feature/user/UserScope.kt	`0.00% <0.00%> (ø)`

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0696b8e...4fb1908. Read the comment docs.

...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt

mchenani

LGTM🛡️, just one last question!

…icate

...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt

ohassine · 2024-01-05T15:43:26Z

...st/kotlin/com/wire/kalium/logic/feature/e2ei/GetMembersE2EICertificateStatusesUseCaseTest.kt

+class GetMembersE2EICertificateStatusesUseCaseTest {
+
+    @Test
+    fun givenErrorOnGettingMembersIdentities_thenEmptyMapResult() = runTest {


For consistency, can we follow the pattern given, when, then ?

...monTest/kotlin/com/wire/kalium/logic/feature/e2ei/GetUserE2eiCertificateStatusUseCaseTest.kt

…icate

borichellow added 2 commits December 28, 2023 12:07

feat: Indicate user with valid E2EI certificate

5196e8e

Merge branch 'develop' into feat/indicate_user_with_valid_e2ei_certif…

a584cc6

…icate

borichellow requested review from mchenani and ohassine December 28, 2023 10:12

borichellow self-assigned this Dec 28, 2023

github-actions bot added 🚨 Potential breaking changes 👕 size: XL type: feature ✨ labels Dec 28, 2023

borichellow added 2 commits December 28, 2023 15:55

Code style fix

1ffe389

Merge branch 'develop' into feat/indicate_user_with_valid_e2ei_certif…

d331336

…icate

borichellow mentioned this pull request Dec 28, 2023

feat: Indicate user with valid E2EI certificate (WPB-3228) wireapp/wire-android#2561

Merged

mchenani reviewed Jan 3, 2024

View reviewed changes

...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt Show resolved Hide resolved

mchenani reviewed Jan 3, 2024

View reviewed changes

...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt Outdated Show resolved Hide resolved

mchenani reviewed Jan 3, 2024

View reviewed changes

persistence/src/commonMain/db_user/com/wire/kalium/persistence/Conversations.sq Outdated Show resolved Hide resolved

feat: Indicate user with valid E2EI certificate: review comments

c628831

mchenani reviewed Jan 4, 2024

View reviewed changes

...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt Show resolved Hide resolved

mchenani reviewed Jan 4, 2024

View reviewed changes

...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/MLSConversationRepository.kt Show resolved Hide resolved

mchenani approved these changes Jan 4, 2024

View reviewed changes

Merge branch 'develop' into feat/indicate_user_with_valid_e2ei_certif…

c86384b

…icate

ohassine reviewed Jan 5, 2024

View reviewed changes

borichellow added 2 commits January 8, 2024 10:53

Merge branch 'develop' into feat/indicate_user_with_valid_e2ei_certif…

14be439

…icate

Review updates

5dea74c

borichellow requested a review from ohassine January 8, 2024 10:55

borichellow added 2 commits January 10, 2024 15:05

Merge branch 'develop' into feat/indicate_user_with_valid_e2ei_certif…

5ced338

…icate

Review fixes

4fb1908

ohassine approved these changes Jan 10, 2024

View reviewed changes

borichellow added this pull request to the merge queue Jan 10, 2024

Merged via the queue into develop with commit 52f2033 Jan 10, 2024
17 checks passed

borichellow deleted the feat/indicate_user_with_valid_e2ei_certificate branch January 10, 2024 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Indicate user with valid E2EI certificate (WPB-3228) #2335

feat: Indicate user with valid E2EI certificate (WPB-3228) #2335

borichellow commented Dec 28, 2023

github-actions bot commented Dec 28, 2023 •

edited

Loading

datadog-wireapp bot commented Dec 28, 2023 •

edited

Loading

codecov-commenter commented Jan 3, 2024 •

edited

Loading

mchenani left a comment

ohassine Jan 5, 2024

feat: Indicate user with valid E2EI certificate (WPB-3228) #2335

feat: Indicate user with valid E2EI certificate (WPB-3228) #2335

Conversation

borichellow commented Dec 28, 2023

What's new in this PR?

Issues

Causes (Optional)

Solutions

github-actions bot commented Dec 28, 2023 • edited Loading

Test Results

datadog-wireapp bot commented Dec 28, 2023 • edited Loading

Datadog Report

codecov-commenter commented Jan 3, 2024 • edited Loading

Codecov Report

mchenani left a comment

Choose a reason for hiding this comment

ohassine Jan 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 28, 2023 •

edited

Loading

datadog-wireapp bot commented Dec 28, 2023 •

edited

Loading

codecov-commenter commented Jan 3, 2024 •

edited

Loading