refactor: remove duplicated legalHoldStatus field from ConversationDetails [WPB-4568]

[saleniuk]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

There were duplicated fields related to legal hold status for conversation - one in Conversation data, which is persisted in the DB and also redundant one added to the ConversationDetails.OneOne and ConversaionDetails.Group.

Solutions

Remove the legalHoldStatus field from ConversationDetails.OneOne and ConversationDetails.Group because it already contains Conversation data which has legalHoldStatus for conversation.

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

2 806 tests  ±0   2 702 ✔️ ±0   2m 46s ⏱️ -17s
   489 suites ±0      104 💤 ±0 
   489 files   ±0          0 ❌ ±0 

Results for commit 4c56555. ± Comparison against base commit 8b74269.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b74269) 58.33% compared to head (4c56555) 58.33%.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2336      +/-   ##
=============================================
- Coverage      58.33%   58.33%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1109     1109              
  Lines          43287    43283       -4     
  Branches        4041     4041              
=============================================
- Hits           25253    25247       -6     
- Misses         16254    16256       +2     
  Partials        1780     1780              

Files	Coverage Δ
...ire/kalium/logic/data/conversation/Conversation.kt	91.01% <ø> (-0.11%)	⬇️
...lium/logic/data/conversation/ConversationMapper.kt	59.94% <ø> (-0.22%)	⬇️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b74269...4c56555. Read the comment docs.

[datadog-wireapp]

Datadog Report

All test runs 4cc064d 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Branch View
kalium-ios	0	0	0	1967	30	11.1s	Link
kalium-jvm	0	0	0	2702	104	8m 55.04s	Link