Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some end points are not routed through the proxy server v4.5 #2485

Merged
merged 12 commits into from
Feb 19, 2024

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

cherry pick #2400 into 4.5

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)
Copy link
Contributor

github-actions bot commented Feb 12, 2024

Unit Test Results

   445 files     445 suites   22s ⏱️
2 524 tests 2 405 ✔️ 119 💤 0

Results for commit 800087e.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 12, 2024

Datadog Report

Branch report: fix/proxy-fix-4.5
Commit report: d02bba0
Test service: kalium-jvm

✅ 0 Failed, 2537 Passed, 104 Skipped, 7m 15s Wall Time

@MohamadJaara MohamadJaara requested review from a team, typfel, yamilmedina, vitorhugods, Garzas and ohassine and removed request for a team February 13, 2024 10:01
@MohamadJaara MohamadJaara changed the title fix: some end points are not routed through the proxy server v4.5 fix: some end points are not routed through the proxy server v4.5 Feb 19, 2024
@MohamadJaara MohamadJaara enabled auto-merge (squash) February 19, 2024 09:47
@MohamadJaara MohamadJaara merged commit 5651bb1 into release/android-cycle-4.5 Feb 19, 2024
17 checks passed
@MohamadJaara MohamadJaara deleted the fix/proxy-fix-4.5 branch February 19, 2024 16:36
MohamadJaara added a commit that referenced this pull request Feb 21, 2024
)

* fix: some end points are not routed through the proxy server (#2400)

* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)

* fix cherry pick issues

* detekt

* trigger CI

* fix import

* fix test

(cherry picked from commit 5651bb1)
MohamadJaara added a commit that referenced this pull request Feb 29, 2024
* fix: some end points are not routed through the proxy server (#2400)

* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)

* fix cherry pick issues

* detekt

* fix: merge issues

* fix: some end points are not routed through the proxy server v4.5 (#2485)

* fix: some end points are not routed through the proxy server (#2400)

* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)

* fix cherry pick issues

* detekt

* trigger CI

* fix import

* fix test

(cherry picked from commit 5651bb1)

* fix: merge issues

* cleanup logs

* address PR comments

---------

Co-authored-by: Alexandre Ferris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants