fix: missing json value pagingState when getting team member by ID #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
cherry-pick
augustocdias
approved these changes
Mar 2, 2024
…hen-getting-team-members-cherry-pick # Conflicts: # logic/src/commonTest/kotlin/com/wire/kalium/logic/data/user/UserRepositoryTest.kt # network/src/commonMain/kotlin/com/wire/kalium/network/api/base/authenticated/TeamsApi.kt # network/src/commonMain/kotlin/com/wire/kalium/network/api/v0/authenticated/TeamsApiV0.kt
Test Results2 310 tests - 646 2 260 ✔️ - 576 14s ⏱️ - 3m 4s Results for commit de9a386. ± Comparison against base commit 00706fc. This pull request removes 2956 and adds 2310 tests. Note that renamed tests count towards both.This pull request removes 120 skipped tests and adds 50 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
MohamadJaara
approved these changes
Mar 5, 2024
MohamadJaara
force-pushed
the
fix/passingState-when-getting-team-members-cherry-pick
branch
from
f07b7c2 to
56bea04
Compare
vitorhugods
deleted the
fix/passingState-when-getting-team-members-cherry-pick
branch
jschumacher-wire
pushed a commit
that referenced
this pull request
Mar 6, 2024
…2578) * Commit with unresolved merge conflicts outside of * resolve conflicts * test --------- Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
logic/src/commonTest/kotlin/com/wire/kalium/logic/data/user/UserRepositoryTest.kt
network/src/commonMain/kotlin/com/wire/kalium/network/api/base/authenticated/TeamsApi.kt
network/src/commonMain/kotlin/com/wire/kalium/network/api/v0/authenticated/TeamsApiV0.kt
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
the changes in #2573 added 2 issues
Solutions
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References