Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing non-mls conversation when app supports MLS but backend doesn't #2579

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Mar 4, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

missing non mls conversation when app supports MLS but backend does not

Causes (Optional)

keep the folloing in mind

  1. kotlin Collection.all function will return true if the collection is empty
  2. for newly created clients, the lastActive value is return as null from the backend.
  3. to check if all of our clients supports MLS we do this
        val allSelfClientsAreMLSCapable = selfClients.filter { it.isActive }.all { it.isMLSCapable }
  1. the result of this is allSelfClientsAreMLSCapable = true and the app will update the supported protocols to include MLS

Solutions

  1. Consider self client as always active
  2. To check if a client is active we check the registration date if the last active date is null

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods changed the title fix: missing non mls conversation when app supports MLS but backend d… fix: missing non-mls conversation when app supports MLS but backend doesn't Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Test Results

2 944 tests   2 821 ✔️  2m 35s ⏱️
   511 suites     123 💤
   511 files           0

Results for commit b9a38c7.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/candidate@11bc5e6). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2579   +/-   ##
====================================================
  Coverage                     ?   58.27%           
  Complexity                   ?        7           
====================================================
  Files                        ?     1175           
  Lines                        ?    45851           
  Branches                     ?     4339           
====================================================
  Hits                         ?    26721           
  Misses                       ?    17185           
  Partials                     ?     1945           
Files Coverage Δ
...n/com/wire/kalium/logic/data/client/ClientModel.kt 97.77% <100.00%> (ø)
...re/user/UpdateSelfUserSupportedProtocolsUseCase.kt 89.39% <89.65%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11bc5e6...b9a38c7. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 4, 2024

Datadog Report

All test runs 68c5199 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2699 129 7m 48.13s Link
kalium-jvm 0 0 0 2821 123 8m 58.01s Link

@MohamadJaara MohamadJaara requested a review from vitorhugods March 4, 2024 13:49
@MohamadJaara MohamadJaara merged commit 010fbfd into release/candidate Mar 4, 2024
17 checks passed
@MohamadJaara MohamadJaara deleted the fix/missing-non-mls-conversations branch March 4, 2024 14:52
github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
…oesn't (#2579)

* fix: missing non mls conversation when app supports MLS but backend does not

* detekt

* address PR comments

* fix
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2024
…oesn't (#2579) (#2582)

* fix: missing non mls conversation when app supports MLS but backend does not

* detekt

* address PR comments

* fix

Co-authored-by: Mohamad Jaara <[email protected]>
jschumacher-wire pushed a commit that referenced this pull request Mar 6, 2024
…oesn't (#2579) (#2582)

* fix: missing non mls conversation when app supports MLS but backend does not

* detekt

* address PR comments

* fix

Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants