-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing non-mls conversation when app supports MLS but backend doesn't #2579
fix: missing non-mls conversation when app supports MLS but backend doesn't #2579
Conversation
...monMain/kotlin/com/wire/kalium/logic/feature/user/UpdateSelfUserSupportedProtocolsUseCase.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2579 +/- ##
====================================================
Coverage ? 58.27%
Complexity ? 7
====================================================
Files ? 1175
Lines ? 45851
Branches ? 4339
====================================================
Hits ? 26721
Misses ? 17185
Partials ? 1945
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
...monMain/kotlin/com/wire/kalium/logic/feature/user/UpdateSelfUserSupportedProtocolsUseCase.kt
Outdated
Show resolved
Hide resolved
…oesn't (#2579) * fix: missing non mls conversation when app supports MLS but backend does not * detekt * address PR comments * fix
…oesn't (#2579) (#2582) * fix: missing non mls conversation when app supports MLS but backend does not * detekt * address PR comments * fix Co-authored-by: Mohamad Jaara <[email protected]>
…oesn't (#2579) (#2582) * fix: missing non mls conversation when app supports MLS but backend does not * detekt * address PR comments * fix Co-authored-by: Mohamad Jaara <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
missing non mls conversation when app supports MLS but backend does not
Causes (Optional)
keep the folloing in mind
Collection.all
function will return true if the collection is emptySolutions
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.