-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: No audio/video when in MLS call (WPB-6984) #2583
fix: No audio/video when in MLS call (WPB-6984) #2583
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2583 +/- ##
====================================================
Coverage ? 58.28%
Complexity ? 7
====================================================
Files ? 1175
Lines ? 45851
Branches ? 4339
====================================================
Hits ? 26723
Misses ? 17184
Partials ? 1944 Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realised that CallManagerImpl
is not testable at the moment.
✅✅✅✅✅
* fix: only call wcall_set_clients_for_conv when conversation protocol is proteus (#2583) * empty trigger commit --------- Co-authored-by: Alexandre Ferris <[email protected]>
* fix: only call wcall_set_clients_for_conv when conversation protocol is proteus (#2583) * empty trigger commit --------- Co-authored-by: Alexandre Ferris <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When in MLS call we would still call
wcall_set_clients_for_conv
Causes (Optional)
wcall_set_clients_for_conv
should be called only when conversation isProteus
Solutions
Wrap calling of
wcall_set_clients_for_conv
only when conversation protocol isProteus
Testing
How to Test