-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade kotlin to 1.9.23 #2586
Conversation
Test Results2 872 tests - 143 2 846 ✔️ - 48 4m 42s ⏱️ + 1m 48s Results for commit b4d4e7c. ± Comparison against base commit 409e685. This pull request removes 3015 and adds 2872 tests. Note that renamed tests count towards both.
This pull request removes 121 skipped tests and adds 26 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2586 +/- ##
=============================================
- Coverage 58.76% 58.74% -0.03%
=============================================
Files 1201 1204 +3
Lines 46836 46865 +29
Branches 4395 4395
=============================================
+ Hits 27524 27530 +6
- Misses 17345 17369 +24
+ Partials 1967 1966 -1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
f95e4f5
to
a8c6acc
Compare
Also update surrounding dependencies to match
1b2ba12
to
4a529a5
Compare
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Other than Kotlin being a bit behind (1.9.0, considering 1.9.22 is available), some other libraries are lagging behind.
Kotlin 2.0 is around the corner and we should try to keep up to catch breaking changes and deal with them earlier.
Solutions
Update as much as we can and reasonably can on
develop
before getting too close to a4.7.0
release. So when we finally make the jump to2.0
(whenever that might be), it won't be as much of a hassle.Important
No Compose/Material updates to avoid breaking UI changes.
The only change was the compose compiler, to keep it compatible with Kotlin 1.9.22. The compiler itself does not change UI looks.
Testing
Ran tests and the Android app locally. Everything alright.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.