Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore MLS error and use concurrent map in the sub conversation #2602

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Ignore MLS error and use concurrent map in the sub conversation


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Test Results

2 832 tests   2 703 ✔️  28s ⏱️
   485 suites     129 💤
   485 files           0

Results for commit c90d555.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 7, 2024

Datadog Report

Branch report: fix/ignore-mls-error
Commit report: 7762fe0
Test service: kalium-jvm

✅ 0 Failed, 2825 Passed, 123 Skipped, 8m 50.05s Wall Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/candidate@8e02495). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2602   +/-   ##
====================================================
  Coverage                     ?   58.28%           
  Complexity                   ?        7           
====================================================
  Files                        ?     1176           
  Lines                        ?    45869           
  Branches                     ?     4345           
====================================================
  Hits                         ?    26735           
  Misses                       ?    17186           
  Partials                     ?     1948           
Files Coverage Δ
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 26.14% <ø> (ø)
...gic/data/conversation/SubconversationRepository.kt 0.00% <0.00%> (ø)
...r/conversation/message/MLSMessageFailureHandler.kt 38.46% <0.00%> (ø)
...in/com/wire/kalium/logic/data/event/EventMapper.kt 22.18% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e02495...61f44d3. Read the comment docs.

@MohamadJaara MohamadJaara enabled auto-merge (squash) March 11, 2024 10:36
@MohamadJaara MohamadJaara merged commit eb46fe3 into release/candidate Mar 11, 2024
17 checks passed
@MohamadJaara MohamadJaara deleted the fix/ignore-mls-error branch March 11, 2024 10:58
github-merge-queue bot pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants