-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: requesting to update E2EI certificate unnecessarily [WPB-7083] #2625
fix: requesting to update E2EI certificate unnecessarily [WPB-7083] #2625
Conversation
Test Results2 193 tests - 791 2 130 ✔️ - 733 16s ⏱️ - 2m 37s Results for commit 2067eaa. ± Comparison against base commit 3442305. This pull request removes 2984 and adds 2193 tests. Note that renamed tests count towards both.
This pull request removes 121 skipped tests and adds 63 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2625 +/- ##
==========================================
Coverage 58.76% 58.76%
Complexity 7 7
==========================================
Files 1189 1189
Lines 46326 46326
Branches 4381 4381
==========================================
Hits 27224 27224
Misses 17150 17150
Partials 1952 1952
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
…en_should_not-cherry-pick
…en_should_not-cherry-pick
…en_should_not-cherry-pick
…en_should_not-cherry-pick
…en_should_not-cherry-pick
…cherry-pick' of github.com:wireapp/kalium into fix/request_to_update_e2ei_certificate_when_should_not-cherry-pick
…en_should_not-cherry-pick
Cherry pick from the original PR:
Merge after
What's new in this PR?
Issues
User is asked to update the E2EI cert when already have it.
Causes (Optional)
The expiration date of the certificate that comes from the CC is a timestamp in SECONDS!!! We were expecting milliseconds.
Solutions
Update mapping timestamp into Instant.