Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requesting to update E2EI certificate unnecessarily [WPB-7083] #2625

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 11, 2024

Cherry pick from the original PR:

Merge after


What's new in this PR?

Issues

User is asked to update the E2EI cert when already have it.

Causes (Optional)

The expiration date of the certificate that comes from the CC is a timestamp in SECONDS!!! We were expecting milliseconds.

Solutions

Update mapping timestamp into Instant.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Mar 11, 2024
@vitorhugods vitorhugods changed the title fix: Request to update E@EI certificate when should not [wpb-7083] fix: requesting to update E2EI certificate when it should not [wpb-7083] Mar 11, 2024
@vitorhugods vitorhugods changed the title fix: requesting to update E2EI certificate when it should not [wpb-7083] fix: requesting to update E2EI certificate unnecessarily [wpb-7083] Mar 11, 2024
@vitorhugods vitorhugods changed the title fix: requesting to update E2EI certificate unnecessarily [wpb-7083] fix: requesting to update E2EI certificate unnecessarily [WPB-7083] Mar 11, 2024
Copy link
Contributor Author

github-actions bot commented Mar 14, 2024

Test Results

2 193 tests   - 791   2 130 ✔️  - 733   16s ⏱️ - 2m 37s
   392 suites  - 124        63 💤  -   58 
   392 files    - 124          0 ±    0 

Results for commit 2067eaa. ± Comparison against base commit 3442305.

This pull request removes 2984 and adds 2193 tests. Note that renamed tests count towards both.
PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenOkHttpSingleton_whenBuildingClearTextTrafficOkhttpClient_thenEnsureConnectionSpecClearText[jvm]
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenTheHttpClientIsCreated_ThenEnsureOnlySupportedSpecsArePresent[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithAccessRoleAndDeprecatedAccessRoleField_whenDecoding_thenDeprecatedFieldIsPreferred[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithDeprecatedAccessRoleField_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayload_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoLocationInHeader_whenCallingSendAcmeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoNonce_whenCallingSendAcmeRequestApi_theResponseShouldBeMissingNonce[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givingASuccessfulResponse_whenGettingACMEFederationCertificateChain_thenAllCertificatesShouldBeParsed[jvm]
…
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenDummyText_whenEncryptedAndDecryptedWithAES256_returnsOriginalText[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAndDecryptedWithAES256_returnsExpectedOriginalFile[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAsAFileAndDecryptedWithAES256AsData_returnsExpectedOriginalFileContent[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAsDataAndDecryptedWithAES256AsAFile_returnsExpectedOriginalFileContent[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ testGivenByteArray_whenCallingCalcMd5_returnsExpectedDigest[iosX64]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ testGivenByteArray_whenCallingCalcSHA256_returnsExpectedDigest[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCertificateRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCheckOrderRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCreateDpopToken_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingFinalizeRequest_ReturnNonEmptyResult[iosX64]
…
This pull request removes 121 skipped tests and adds 63 skipped tests. Note that renamed tests count towards both.
PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGeTrustAnchorsApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendChallengeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenActivationEmailWIthCode_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenRegisteringAccountWithEMail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenSendingActivationEmail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenActivationCodeFail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenRegistrationFail_whenRegisteringAccountWithEMMail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenSendActivationCodeFail_thenErrorIsPropagated[jvm]
…
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCertificateRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCheckOrderRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingCreateDpopToken_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingFinalizeRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewAccountRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewAuthzRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewDpopChallengeRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewOidcChallengeRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenCallingGetNewOrderRequest_ReturnNonEmptyResult[iosX64]
com.wire.kalium.cryptography.E2EIClientTest ‑ givenClient_whenPassingAcmeDirectoryResponse_ReturnNonEmptyResult[iosX64]
…

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.76%. Comparing base (3442305) to head (2067eaa).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2625   +/-   ##
==========================================
  Coverage      58.76%   58.76%           
  Complexity         7        7           
==========================================
  Files           1189     1189           
  Lines          46326    46326           
  Branches        4381     4381           
==========================================
  Hits           27224    27224           
  Misses         17150    17150           
  Partials        1952     1952           
Files Coverage Δ
...monMain/kotlin/com/wire/kalium/cryptography/IDs.kt 87.50% <100.00%> (ø)
.../wire/kalium/logic/feature/e2ei/E2eiCertificate.kt 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3442305...2067eaa. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 14, 2024

Datadog Report

All test runs 7ead6b1 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2130 63 8m 24.11s Link
kalium-jvm 0 0 0 2863 121 8m 57.04s Link

@MohamadJaara MohamadJaara added this pull request to the merge queue Mar 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 15, 2024
@ohassine ohassine added this pull request to the merge queue Mar 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 15, 2024
@saleniuk saleniuk enabled auto-merge March 15, 2024 11:46
…cherry-pick' of github.com:wireapp/kalium into fix/request_to_update_e2ei_certificate_when_should_not-cherry-pick
@saleniuk saleniuk added this pull request to the merge queue Mar 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 15, 2024
@saleniuk saleniuk enabled auto-merge March 15, 2024 13:03
@saleniuk saleniuk added this pull request to the merge queue Mar 15, 2024
Merged via the queue into develop with commit 4b3655c Mar 15, 2024
17 checks passed
@saleniuk saleniuk deleted the fix/request_to_update_e2ei_certificate_when_should_not-cherry-pick branch March 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants