-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missing MLS Conversation (WPB-7085) #2629
fix: Missing MLS Conversation (WPB-7085) #2629
Conversation
* fix: invert order for fetching conversation if unknown * fix: tests
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2629 +/- ##
=============================================
- Coverage 58.60% 58.59% -0.01%
Complexity 7 7
=============================================
Files 1183 1183
Lines 45929 45928 -1
Branches 4331 4331
=============================================
- Hits 26916 26912 -4
- Misses 17079 17081 +2
- Partials 1934 1935 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
In the logs we would get errors: followed by
Solutions
As we receive the from the MLSWelcome event, we can first try to fetch conversation if its unknown then get MLSClient
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References