Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing MLS Conversation (WPB-7085) #2629

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

In the logs we would get errors: followed by

Solutions

As we receive the from the MLSWelcome event, we can first try to fetch conversation if its unknown then get MLSClient

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

* fix: invert order for fetching conversation if unknown

* fix: tests
@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Mar 11, 2024
Copy link
Contributor Author

github-actions bot commented Mar 12, 2024

Test Results

2 961 tests  ±0   2 841 ✔️ ±0   2m 38s ⏱️ +9s
   514 suites ±0      120 💤 ±0 
   514 files   ±0          0 ±0 

Results for commit 3e0e71f. ± Comparison against base commit 053107e.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 12, 2024

Datadog Report

All test runs 4089605 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2090 37 11.11s Link
kalium-jvm 0 0 0 2841 120 9m 2.04s Link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.59%. Comparing base (053107e) to head (3e0e71f).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2629      +/-   ##
=============================================
- Coverage      58.60%   58.59%   -0.01%     
  Complexity         7        7              
=============================================
  Files           1183     1183              
  Lines          45929    45928       -1     
  Branches        4331     4331              
=============================================
- Hits           26916    26912       -4     
- Misses         17079    17081       +2     
- Partials        1934     1935       +1     
Files Coverage Δ
...nc/receiver/conversation/MLSWelcomeEventHandler.kt 90.32% <100.00%> (-0.16%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053107e...3e0e71f. Read the comment docs.

@alexandreferris alexandreferris added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit 19f215e Mar 12, 2024
17 checks passed
@alexandreferris alexandreferris deleted the fix/missing_mls_conversation-cherry-pick branch March 12, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: XS type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants