-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SetVideoSendStateUseCase (WPB-7114) #2670
Conversation
Test Results2 997 tests +1 2 876 ✔️ +1 2m 54s ⏱️ +6s Results for commit 4fc22b9. ± Comparison against base commit 91c3be1. This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but this need to be cherry-picked into RC
… calling_video_not_streamed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2670 +/- ##
=============================================
- Coverage 58.71% 58.71% -0.01%
Complexity 7 7
=============================================
Files 1188 1189 +1
Lines 46512 46511 -1
Branches 4386 4384 -2
=============================================
- Hits 27311 27310 -1
- Misses 17241 17242 +1
+ Partials 1960 1959 -1
Continue to review full report in Codecov by Sentry.
|
#2670) (#2679) (#2839) Co-authored-by: Oussama Hassine <[email protected]>
#2670) (#2679) (#2840) Co-authored-by: Oussama Hassine <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Description
Moving the logic of updating send state to a separate usecase.
Needed for wireapp/wire-android#2801
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.