chore(deps): bump sqldelight from 2.0.1 to 2.0.2 (WPB-10501) #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
requested review from
a team,
alexandreferris,
mchenani,
Garzas,
ohassine and
saleniuk
and removed request for
a team
ohassine
approved these changes
Apr 24, 2024
Bumps `sqldelight` from 2.0.1 to 2.0.2. Updates `app.cash.sqldelight:runtime` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:coroutines-extensions` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:android-driver` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:androidx-paging3-extensions` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:native-driver` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:sqlite-driver` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:web-worker-driver` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:primitive-adapters` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:sqlite-3-38-dialect` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:postgresql-dialect` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:r2dbc-driver` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight:async-extensions` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) Updates `app.cash.sqldelight` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/cashapp/sqldelight/releases) - [Changelog](https://github.com/cashapp/sqldelight/blob/master/CHANGELOG.md) - [Commits](sqldelight/sqldelight@2.0.1...2.0.2) --- updated-dependencies: - dependency-name: app.cash.sqldelight:runtime dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:coroutines-extensions dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:android-driver dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:androidx-paging3-extensions dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:native-driver dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:sqlite-driver dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:web-worker-driver dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:primitive-adapters dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:sqlite-3-38-dialect dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:postgresql-dialect dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:r2dbc-driver dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight:async-extensions dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: app.cash.sqldelight dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/gradle/sqldelight-2.0.2
branch
from
6d71a92 to
9c2eecd
Compare
MohamadJaara
approved these changes
Apr 24, 2024
yamilmedina
requested changes
Apr 25, 2024
|
Datadog ReportBranch report: ❌ 9 Failed (0 Known Flaky), 2913 Passed, 52 Skipped, 12.37s Total Time ❌ Failed Tests (9)
|
|
Seems to be a bug within SqlDelight. We will need a 2.0.3 build. So, I'll investigate further. This is the query that is facing issues: getNotificationsMessages:
WITH NumberedMessages AS (
SELECT
-- other fields
ROW_NUMBER() OVER (PARTITION BY m.conversation_id ORDER BY m.creation_date DESC) AS row_num
FROM
Message m
JOIN
User u ON m.sender_user_id = u.qualified_id
JOIN
Conversation c ON m.conversation_id = c.qualified_id
LEFT JOIN
MessageAssetContent ac ON m.id = ac.message_id AND m.conversation_id = ac.conversation_id
LEFT JOIN
MessageTextContent tc ON m.id = tc.message_id AND m.conversation_id = tc.conversation_id
WHERE
-- Criteria
)
SELECT
-- some fields
FROM
NumberedMessages
WHERE
row_num <= 10
ORDER BY
date DESC;However, take a look into the WITH NumberedMessages AS (
SELECT
-- more fields
row_num -- It completely removed the rest of the query here
FROM
Message m
JOIN
User u ON m.sender_user_id = u.qualified_id
JOIN
Conversation c ON m.conversation_id = c.qualified_id
LEFT JOIN |
Datadog ReportBranch report: ✅ 0 Failed, 1 Passed, 0 Skipped, 0s Total Time |
|
yamilmedina
changed the title
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
|
Bencher Report| Branch | dependabot/gradle/sqldelight-2.0.2 |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 661,740.43 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 389,001,413.34 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,355,384,820.72 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 22,048,196.67 |
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
|
|
Raised issue on SQLDelight bug tracker. |
|
Closing it for now. We definitely can't update to 2.0.2 and it would be nice to have dependabot work on other things :) |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
sqldelightfrom 2.0.1 to 2.0.2.Updates
app.cash.sqldelight:runtimefrom 2.0.1 to 2.0.2Release notes
Sourced from app.cash.sqldelight:runtime's releases.
... (truncated)
Changelog
Sourced from app.cash.sqldelight:runtime's changelog.
Commits
a82c184Prepare for release 2.0.23a778a7Inline the column names for SELECT * (#5054)ebabf09Use the extensions array instead of stream (#5127)b372df0Bump intellij version (#4983)ad70ba1Dont bundle the kotlin lib into the intellij plugin as its already a plugin d...b5d9d3fFixes 5032 column adjacency for PostgreSql UPDATE FROM statement (#5035)aa41c0bSpecify the thread to use for the connection list clear action (#5125)2c54d9eUpdate plugin ksp to v1.9.23-1.0.20 (#5121)918fc32Update build.gradle (#5118)5628209Fixes 5082 tsvector (#5104)Updates
app.cash.sqldelight:coroutines-extensionsfrom 2.0.1 to 2.0.2Release notes
Sourced from app.cash.sqldelight:coroutines-extensions's releases.
... (truncated)
Changelog
Sourced from app.cash.sqldelight:coroutines-extensions's changelog.
Commits
a82c184Prepare for release 2.0.23a778a7Inline the column names for SELECT * (#5054)ebabf09Use the extensions array instead of stream (#5127)b372df0Bump intellij version (#4983)ad70ba1Dont bundle the kotlin lib into the intellij plugin as its already a plugin d...b5d9d3fFixes 5032 column adjacency for PostgreSql UPDATE FROM statement (#5035)aa41c0bSpecify the thread to use for the connection list clear action (#5125)2c54d9eUpdate plugin ksp to v1.9.23-1.0.20 (#5121)918fc32Update build.gradle (#5118)5628209Fixes 5082 tsvector (#5104)Updates
app.cash.sqldelight:android-driverfrom 2.0.1 to 2.0.2Release notes
Sourced from app.cash.sqldelight:android-driver's releases.
... (truncated)
Changelog
Sourced from app.cash.sqldelight:android-driver's changelog.
Commits
a82c184Prepare for release 2.0.23a778a7Inline the column names for SELECT * (#5054)ebabf09Use the extensions array instead of stream (#5127)b372df0Bump intellij version (#4983)ad70ba1Dont bundle the kotlin lib into the intellij plugin as its already a plugin d...b5d9d3fFixes 5032 column adjacency for PostgreSql UPDATE FROM statement (#5035)aa41c0bSpecify the thread to use for the connection list clear action (#5125)2c54d9eUpdate plugin ksp to v1.9.23-1.0.20 (#5121)918fc32Update build.gradle (#5118)5628209Fixes 5082 tsvector (#5104)Updates
app.cash.sqldelight:androidx-paging3-extensionsfrom 2.0.1 to 2.0.2Release notes
Sourced from app.cash.sqldelight:androidx-paging3-extensions's releases.
... (truncated)
Changelog
Sourced from app.cash.sqldelight:androidx-paging3-extensions's changelog.
Commits
a82c184Prepare for release 2.0.23a778a7Inline the column names for SELECT * (#5054)ebabf09Use the extensions array instead of stream (#5127)b372df0Bump intellij version (#4983)ad70ba1Dont bundle the kotlin lib into the intellij plugin as its already a plugin d...b5d9d3fFixes 5032 column adjacency for PostgreSql UPDATE FROM statement (#5035)aa41c0bSpecify the thread to use for the connection list clear action (#5125)2c54d9eUpdate plugin ksp to v1.9.23-1.0.20 (#5121)918fc32Update build.gradle (#5118)5628209Fixes 5082 tsvector (#5104)Updates
app.cash.sqldelight:native-driverfrom 2.0.1 to 2.0.2Release notes
Sourced from app.cash.sqldelight:native-driver's releases.
... (truncated)
Changelog
Sourced from app.cash.sqldelight:native-driver's changelog.