fix: asset restriction [WPB-9947] (#2831) #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: asset sending restriction * add test * add error messages and detekt * fist test service * detekt * chore: update gradle-ios-tests.yml for runner at that time --------- Co-authored-by: Yamil Medina <[email protected]> (cherry picked from commit ebcc9f8)
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
MohamadJaara
requested review from
a team,
typfel,
alexandreferris,
vitorhugods,
mchenani and
Garzas
and removed request for
a team
MohamadJaara
changed the title
alexandreferris
approved these changes
Jul 2, 2024
vitorhugods
approved these changes
Jul 2, 2024
MohamadJaara
added a commit
that referenced
this pull request
Jul 2, 2024
* fix: asset restriction (#2831) * fix: asset sending restriction * add test * add error messages and detekt * fist test service * detekt * chore: update gradle-ios-tests.yml for runner at that time --------- Co-authored-by: Yamil Medina <[email protected]> (cherry picked from commit ebcc9f8) * fix merge issues * fix unresolved reference (cherry picked from commit 116f276)
MohamadJaara
added a commit
that referenced
this pull request
Jul 3, 2024
* fix: asset restriction [WPB-9947] (#2831) (#2856) * fix: asset restriction (#2831) * fix: asset sending restriction * add test * add error messages and detekt * fist test service * detekt * chore: update gradle-ios-tests.yml for runner at that time --------- Co-authored-by: Yamil Medina <[email protected]> (cherry picked from commit ebcc9f8) * fix merge issues * fix unresolved reference (cherry picked from commit 116f276) * merge conflicts
MohamadJaara
added a commit
that referenced
this pull request
Jul 8, 2024
* Commit with unresolved merge conflicts * asset restriction * fix tests --------- Co-authored-by: Mohamad Jaara <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Jul 8, 2024
* Commit with unresolved merge conflicts * asset restriction * fix tests --------- Co-authored-by: Mohamad Jaara <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Commit with unresolved merge conflicts * asset restriction * fix tests --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mohamad Jaara <[email protected]>
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: asset sending restriction
add test
add error messages and detekt
fist test service
detekt
chore: update gradle-ios-tests.yml for runner at that time
Co-authored-by: Yamil Medina [email protected]
(cherry picked from commit ebcc9f8)
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When sending a new file, assets restrictions are not considered.
Solutions
check the file restrictions status and return the correct error based on that
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.