Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add bencher to ci for benchmarks storage (WPB-8645) #2901

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 25, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Add and use reports storage and visualization for benchmarks using bencher.dev, since now @wireapp/core-libraries team introduced this for their Core-crypto project


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wire 2024-05-23 at 12_17 PM

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Test Results

3 133 tests  ±0   3 028 ✔️ ±0   3m 39s ⏱️ +7s
   538 suites ±0      105 💤 ±0 
   538 files   ±0          0 ±0 

Results for commit 9b543aa. ± Comparison against base commit 337c415.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jul 25, 2024

Datadog Report

Branch report: chore/bencher-for-benchmarks
Commit report: b38c1c3
Test service: kalium-jvm

✅ 0 Failed, 3028 Passed, 105 Skipped, 11.88s Total Time

Copy link

Copy link
Contributor

🐰Bencher

ReportThu, July 25, 2024 at 15:44:32 UTC
Projectkalium
Branchchore/bencher-for-benchmarks
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)687,788.77
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)340,896,513.78
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)924,465,899.76
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,576,346.85

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@yamilmedina yamilmedina added this pull request to the merge queue Jul 25, 2024
Merged via the queue into develop with commit 706d901 Jul 25, 2024
22 checks passed
@yamilmedina yamilmedina deleted the chore/bencher-for-benchmarks branch July 25, 2024 16:35
MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024
* ci: add bencher to ci for benchmarks storage

* ci: add bencher to ci for benchmarks storage

* ci: add bencher to ci for benchmarks storage

* ci: add bencher to ci for benchmarks storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants