fix: missing notifications due to LegalHold not Notified (WPB-10351) #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
requested review from
borichellow,
MohamadJaara,
mchenani,
saleniuk and
a team
yamilmedina
requested review from
alexandreferris
and removed request for
a team
yamilmedina
changed the title
|
borichellow
approved these changes
Jul 26, 2024
yamilmedina
commented
Jul 26, 2024
| @@ -16,12 +16,12 @@ SELECT | |||
| Conversation.type AS conversationType, | |||
| Conversation.degraded_conversation_notified AS degradedConversationNotified, | |||
| Conversation.legal_hold_status AS legalHoldStatus, | |||
| LegalHoldNotified.legal_hold_status_change_notified AS legalHoldStatusChangeNotified | |||
| IFNULL(LegalHoldNotified.legal_hold_status_change_notified, 1) == 1 AS legalHoldStatusChangeNotified | |||
There was a problem hiding this comment.
Here I assumed the default value from the table (Boolean = 1), but please @borichellow that has more context, correct me if otherwise :D
MohamadJaara
approved these changes
Jul 26, 2024
Datadog ReportBranch report: ✅ 0 Failed, 2923 Passed, 107 Skipped, 6.3s Total Time |
This was referenced Jul 26, 2024
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
This PR solves a bug introduced by #2874 , assuming that we have always a notification about LH in the conversations
Causes (Optional)
Notifications not being received
Solutions
LEFT join and assume true (same default value for the table) in case missing.
Added test to cover the case.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.