Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newly created 1:1 with bots are not displayed [WPB-4464] #2912

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 27, 2024

BugWPB-4464 [Android] 1:1 with bots are displayed as deleted account group conversation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

newly created 1:1 with bots are not displayed
the intreduction of activeOneOnOne in the user table for MLS migration lead to this case
it was handled when a new converastion is created, but for bots the conversation is created empty first and then transformed into a 1:1

Solutions

update the active 1:1 when a member is added to a 1:1 conversation

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Test Results

2 967 tests   2 950 ✔️  1h 4m 49s ⏱️
       5 suites       17 💤
       5 files           0

Results for commit 00fcd08.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/candidate@179c081). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2912   +/-   ##
====================================================
  Coverage                     ?   52.47%           
====================================================
  Files                        ?     1287           
  Lines                        ?    49438           
  Branches                     ?     4619           
====================================================
  Hits                         ?    25944           
  Misses                       ?    21635           
  Partials                     ?     1859           
Files Coverage Δ
.../kotlin/com/wire/kalium/persistence/dao/UserDAO.kt 96.29% <ø> (ø)
...nc/receiver/conversation/MemberJoinEventHandler.kt 91.30% <50.00%> (ø)
.../com/wire/kalium/logic/data/user/UserRepository.kt 69.40% <25.00%> (ø)
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 54.76% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179c081...14b7c21. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jul 27, 2024

Datadog Report

Branch report: fix/1-1-with-bots
Commit report: adda45e
Test service: kalium-jvm

✅ 0 Failed, 3030 Passed, 105 Skipped, 11.54s Total Time

@MohamadJaara MohamadJaara changed the title fix: newly created 1:1 with bots are not displayed fix: newly created 1:1 with bots are not displayed [WPB-4464] Jul 27, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 27, 2024
Copy link

@MohamadJaara MohamadJaara added this pull request to the merge queue Jul 30, 2024
@MohamadJaara MohamadJaara removed this pull request from the merge queue due to a manual request Jul 30, 2024
@MohamadJaara MohamadJaara merged commit e2ac7c3 into release/candidate Jul 30, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the fix/1-1-with-bots branch July 30, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants