fix: send calling message in order [WPB-10051] #2920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually cherry picked from #2915:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Calling messages are not always sent in order. Leading to issues like "Join" button getting stuck on Android.
Causes
AVS asks us to send OTR messages.
We delegate that to
MessageSender
, which has no order guarantee.If called with two messages and one takes longer than the other, the
MessageSender
might switch the order around.Solutions
OnHttpRequest
toCallingMessageSender
, which is focused exactly on sending calling messages.CallingMessageInstructions
to process in order.Testing
Test Coverage
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.