fix: delete assets locally when message is deleted [WPB-9466] #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
saleniuk
requested review from
a team,
yamilmedina,
alexandreferris,
MohamadJaara,
mchenani and
Garzas
and removed request for
a team
Datadog ReportBranch report: ✅ 0 Failed, 3034 Passed, 105 Skipped, 10.13s Total Time |
|
alexandreferris
approved these changes
Aug 2, 2024
MohamadJaara
approved these changes
Aug 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* fix: delete assets locally when message is deleted [WPB-9466] * detekt * do not return failure when removing asset
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* fix: delete assets locally when message is deleted [WPB-9466] (#2925) * fix: delete assets locally when message is deleted [WPB-9466] * detekt * do not return failure when removing asset * trigger build --------- Co-authored-by: Michał Saleniuk <[email protected]> Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When deleting an assets message the local file inside the app is not deleted.
Solutions
Implement removing asset from assets table and asset file downloaded and stored locally when the message containing this asset is removed. For sent self-deleting message, assets are removed when the message is marked as deleted and content is cleared.
Testing
Test Coverage (Optional)
How to Test
Remove some messages with assets and check if assets are still in app
filesdirectory and/or these assets are still in assets table.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.