Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: missing codecov token (WPB-8645) #2927

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 1, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Version 3 was deprecated form codecov (tokenless uploads)

Causes (Optional)

Rate limit hit while trying to upload report

Solutions

Update action and pass the secret when calling the workflow.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Aug 1, 2024
@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris, MohamadJaara, vitorhugods and ohassine and removed request for a team August 1, 2024 20:17
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test Results

3 144 tests  ±0   3 039 ✔️ ±0   3m 50s ⏱️ -1s
   539 suites ±0      105 💤 ±0 
   539 files   ±0          0 ±0 

Results for commit 3e055ed. ± Comparison against base commit 9dbf5f5.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Aug 1, 2024

Copy link
Contributor

github-actions bot commented Aug 1, 2024

🐰Bencher

ReportThu, August 1, 2024 at 20:39:39 UTC
Projectkalium
Branchfix/codecov4withtoken
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)685,114.15
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)340,208,172.69
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)935,698,296.40
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,928,822.20

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.52%. Comparing base (21725e7) to head (3e055ed).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2927   +/-   ##
========================================
  Coverage    52.52%   52.52%           
========================================
  Files         1290     1290           
  Lines        49441    49449    +8     
  Branches      4595     4594    -1     
========================================
+ Hits         25970    25975    +5     
- Misses       21629    21632    +3     
  Partials      1842     1842           

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbf5f5...3e055ed. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/codecov4withtoken
Commit report: 83999f1
Test service: kalium-jvm

✅ 0 Failed, 3039 Passed, 105 Skipped, 15.21s Total Time

@yamilmedina yamilmedina enabled auto-merge August 2, 2024 07:32
@yamilmedina yamilmedina added this pull request to the merge queue Aug 2, 2024
Merged via the queue into develop with commit 2829746 Aug 2, 2024
22 checks passed
@yamilmedina yamilmedina deleted the fix/codecov4withtoken branch August 2, 2024 08:15
MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024
* fix: codecov 4 with token

* chore: empty commit bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants