fix(e2ei): set ciphersuites when replacing KeyPackages (WPB-10238) 🍒 🍒 #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…2921) * Commit with unresolved merge conflicts * resolve conflicts after cherry pick --------- Co-authored-by: Mojtaba Chenani <[email protected]>
github-actions
bot
added
cherry-pick
mchenani
approved these changes
Aug 5, 2024
|
Test Results3 149 tests +2 3 044 ✔️ +2 3m 42s ⏱️ -20s Results for commit 8f126b6. ± Comparison against base commit 859dab6. This pull request removes 14 and adds 16 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
| Report | Mon, August 5, 2024 at 09:46:55 UTC |
| Project | kalium |
| Branch | fix/set-cs-when-replacing-keypackages-cherry-pick-cherry-pick |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | ➖ (view plot) | 684,268.02 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | ➖ (view plot) | 407,322,937.01 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | ➖ (view plot) | 927,219,095.83 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | ➖ (view plot) | 21,281,713.39 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2931 +/- ##
===========================================
- Coverage 52.54% 52.53% -0.01%
===========================================
Files 1289 1289
Lines 49503 49508 +5
Branches 4598 4598
===========================================
+ Hits 26009 26011 +2
- Misses 21654 21657 +3
Partials 1840 1840
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3044 Passed, 105 Skipped, 13.35s Total Time |
ohassine
approved these changes
Aug 5, 2024
mchenani
deleted the
fix/set-cs-when-replacing-keypackages-cherry-pick-cherry-pick
branch
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
After finding some issues on the backend, now it's mandatory to set the CipherSuite when replacing keypackages after E2EI.
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.