Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core-crypto): update CoreCrypto to 1.0.2 (WPB-9118) #2937

Merged
merged 10 commits into from
Aug 22, 2024
Merged

chore(core-crypto): update CoreCrypto to 1.0.2 (WPB-9118) #2937

merged 10 commits into from
Aug 22, 2024

Conversation

mchenani
Copy link
Contributor

@mchenani mchenani commented Aug 7, 2024

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Update CoreCrypto to 1.0.1 to include the fix for generating X509 KeyPackage after E2EI.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 7, 2024
@mchenani mchenani enabled auto-merge (squash) August 7, 2024 08:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Test Results

2 927 tests   2 804 ✔️  24s ⏱️
   497 suites     123 💤
   497 files           0 ❌

Results for commit f9c8140.

♻️ This comment has been updated with latest results.

@mchenani mchenani changed the title chore(CC): update CoreCrytpto to 1.0.1 (WPB-9118) chore(core-crypto): update CoreCrytpto to 1.0.1 (WPB-9118) Aug 7, 2024
@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 7, 2024 •
edited
Loading

Datadog Report

All test runs 90c7ee1 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2795 123 1.6s Link
kalium-jvm 0 0 0 2943 107 4.9s Link

@mythsunwind mythsunwind changed the title chore(core-crypto): update CoreCrytpto to 1.0.1 (WPB-9118) chore(core-crypto): update CoreCrypto to 1.0.2 (WPB-9118) Aug 22, 2024
typfel
typfel reviewed Aug 22, 2024
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mchenani mchenani merged commit f36cbdf into release/android-cycle-4.6 Aug 22, 2024
19 checks passed
@mchenani mchenani deleted the chore/update-corecrypto-1.0.1 branch August 22, 2024 11:31
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
@mchenani @github-actions
chore(CC): update CoreCrypto to 1.0.1 (#2937)
85dba68
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this pull request Aug 23, 2024
@github-actions @mchenani @ohassine
chore(CC): update CoreCrypto to 1.0.1 (#2937) (#2963)
851aff7 
Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Oussama Hassine <[email protected]>
github-actions bot added a commit that referenced this pull request Aug 23, 2024
@github-actions @mchenani @ohassine
chore(CC): update CoreCrypto to 1.0.1 (#2937) (#2963)
6fec0a3 
Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Oussama Hassine <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2024
@github-actions @mchenani
@ohassine @yamilmedina
chore(CC): update CoreCrypto to 1.0.1 (#2937) (#2963) (#2967)
889708d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Oussama Hassine <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typfel typfel typfel left review comments

@ohassine ohassine ohassine approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

Assignees

@mchenani mchenani

Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: S type: chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mchenani @typfel @MohamadJaara @ohassine